Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(306)

Issue 29339199: Issue 3846 - Add notification for users using an old SBrowser version (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 8 months ago by René Jeschke
Modified:
3 years, 7 months ago
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Issue 3846 - Add notification for users using an old SBrowser version

Patch Set 1 #

Total comments: 10

Patch Set 2 : Removed version bump #

Patch Set 3 : ...AndProceed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -27 lines) Patch
M AndroidManifest.xml View 1 1 chunk +1 line, -1 line 0 comments Download
A res/raw/sbrowser_dialog.html View 1 chunk +2 lines, -0 lines 0 comments Download
M res/values/strings.xml View 1 chunk +2 lines, -0 lines 0 comments Download
M src/org/adblockplus/sbrowser/contentblocker/MainPreferences.java View 1 2 4 chunks +67 lines, -26 lines 0 comments Download
M src/org/adblockplus/sbrowser/contentblocker/engine/Engine.java View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8
René Jeschke
3 years, 8 months ago (2016-03-31 13:19:20 UTC) #1
Felix Dahlke
Looks good all in all, just a few comments. https://codereview.adblockplus.org/29339199/diff/29339200/AndroidManifest.xml File AndroidManifest.xml (right): https://codereview.adblockplus.org/29339199/diff/29339200/AndroidManifest.xml#newcode5 AndroidManifest.xml:5: ...
3 years, 8 months ago (2016-04-01 08:54:54 UTC) #2
René Jeschke
https://codereview.adblockplus.org/29339199/diff/29339200/AndroidManifest.xml File AndroidManifest.xml (right): https://codereview.adblockplus.org/29339199/diff/29339200/AndroidManifest.xml#newcode5 AndroidManifest.xml:5: android:versionName="1.0.2" > On 2016/04/01 08:54:53, Felix Dahlke wrote: > ...
3 years, 8 months ago (2016-04-10 22:03:26 UTC) #3
Felix Dahlke
https://codereview.adblockplus.org/29339199/diff/29339200/src/org/adblockplus/sbrowser/contentblocker/MainPreferences.java File src/org/adblockplus/sbrowser/contentblocker/MainPreferences.java (right): https://codereview.adblockplus.org/29339199/diff/29339200/src/org/adblockplus/sbrowser/contentblocker/MainPreferences.java#newcode110 src/org/adblockplus/sbrowser/contentblocker/MainPreferences.java:110: this.checkAAStatus(); On 2016/04/10 22:03:25, René Jeschke wrote: > Returning ...
3 years, 8 months ago (2016-04-11 13:53:48 UTC) #4
René Jeschke
https://codereview.adblockplus.org/29339199/diff/29339200/src/org/adblockplus/sbrowser/contentblocker/MainPreferences.java File src/org/adblockplus/sbrowser/contentblocker/MainPreferences.java (right): https://codereview.adblockplus.org/29339199/diff/29339200/src/org/adblockplus/sbrowser/contentblocker/MainPreferences.java#newcode110 src/org/adblockplus/sbrowser/contentblocker/MainPreferences.java:110: this.checkAAStatus(); On 2016/04/11 13:53:48, Felix Dahlke wrote: > On ...
3 years, 8 months ago (2016-04-12 09:10:05 UTC) #5
Felix Dahlke
https://codereview.adblockplus.org/29339199/diff/29339200/src/org/adblockplus/sbrowser/contentblocker/MainPreferences.java File src/org/adblockplus/sbrowser/contentblocker/MainPreferences.java (right): https://codereview.adblockplus.org/29339199/diff/29339200/src/org/adblockplus/sbrowser/contentblocker/MainPreferences.java#newcode110 src/org/adblockplus/sbrowser/contentblocker/MainPreferences.java:110: this.checkAAStatus(); On 2016/04/12 09:10:04, René Jeschke wrote: > On ...
3 years, 8 months ago (2016-04-12 11:44:46 UTC) #6
René Jeschke
https://codereview.adblockplus.org/29339199/diff/29339200/src/org/adblockplus/sbrowser/contentblocker/MainPreferences.java File src/org/adblockplus/sbrowser/contentblocker/MainPreferences.java (right): https://codereview.adblockplus.org/29339199/diff/29339200/src/org/adblockplus/sbrowser/contentblocker/MainPreferences.java#newcode110 src/org/adblockplus/sbrowser/contentblocker/MainPreferences.java:110: this.checkAAStatus(); On 2016/04/12 11:44:46, Felix Dahlke wrote: > On ...
3 years, 8 months ago (2016-04-12 13:32:39 UTC) #7
Felix Dahlke
3 years, 8 months ago (2016-04-12 15:03:16 UTC) #8
Beautiful, LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5