Issue 29339280: No issue - update google test framework

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29339280: No issue - update google test framework (Closed)

Created:
April 1, 2016, 2:32 p.m. by sergei

Modified:
April 1, 2016, 2:55 p.m.

Reviewers:
René Jeschke

CC:
Felix Dahlke, Oleksandr, Eric

Visibility:
Public.

Description

#project: libadblockplus Because of compilation errors using newer compiler from android ndk r10c and r10d we had to update google testing framework. Code review: https://codereview.adblockplus.org/29339280/ # Compilation has been tested with android-ndk-r9d, android-ndk-r10d as well as with running tests compiled by gcc 5.2.1 and MSVS2012.

Patch Set 1 #

Created: April 1, 2016, 2:32 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -13 lines)			Patch
	M	dependencies	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	third_party/googletest.gyp	View		2 chunks	+12 lines, -12 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Assuming it works

Expand All Messages | Collapse All Messages