Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29339346: Noissue - Removed obsolete nsIURI compatbility code (Closed)

Created:
April 4, 2016, 11:20 a.m. by Sebastian Noack
Modified:
April 5, 2016, 12:15 p.m.
Reviewers:
Wladimir Palant
CC:
kzar
Visibility:
Public.

Description

Noissue - Removed obsolete nsIURI compatbility code

Patch Set 1 #

Total comments: 2

Patch Set 2 : Completly remove Utils.makeURI() #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
M lib/compat.js View 1 chunk +0 lines, -25 lines 0 comments Download
M lib/utils.js View 1 1 chunk +0 lines, -5 lines 1 comment Download

Messages

Total messages: 4
Sebastian Noack
https://codereview.adblockplus.org/29339346/diff/29339347/lib/compat.js File lib/compat.js (left): https://codereview.adblockplus.org/29339346/diff/29339347/lib/compat.js#oldcode137 lib/compat.js:137: newURI: function(uri) These functions aren't called (directly) on Chrome ...
April 4, 2016, 11:22 a.m. (2016-04-04 11:22:26 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29339346/diff/29339369/lib/utils.js File lib/utils.js (left): https://codereview.adblockplus.org/29339346/diff/29339369/lib/utils.js#oldcode56 lib/utils.js:56: makeURI: function(url) Actually we don't even need that function ...
April 4, 2016, 1:46 p.m. (2016-04-04 13:46:43 UTC) #2
Sebastian Noack
Since Dave is currently traveling, I put you as reviewer.
April 4, 2016, 1:53 p.m. (2016-04-04 13:53:15 UTC) #3
Wladimir Palant
April 4, 2016, 2:01 p.m. (2016-04-04 14:01:58 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld