Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: options.js

Issue 29339395: Noissue - Make the options page respond to subscription title and homepage changes (Closed)
Patch Set: Created April 5, 2016, 7:05 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« messageResponder.js ('K') | « messageResponder.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: options.js
===================================================================
--- a/options.js
+++ b/options.js
@@ -445,7 +445,9 @@
if (knownSubscription)
{
for (var property in subscription)
Thomas Greiner 2016/04/06 13:51:18 Detail: I know that this is valid JavaScript and I
Sebastian Noack 2016/04/06 17:26:29 Done.
- if (property != "title")
+ if (property == "title" && subscription.url in recommendationsMap)
Thomas Greiner 2016/04/06 13:51:18 Detail: I noticed that there's a variable `subscri
Sebastian Noack 2016/04/06 17:26:29 Done.
+ knownSubscription.originalTitle = subscription.title;
+ else
knownSubscription[property] = subscription[property];
}
else
@@ -975,14 +977,6 @@
updateSubscription(subscription);
updateShareLink();
break;
- case "lastDownload":
- case "downloadStatus":
- case "downloading":
- updateSubscription(subscription);
- break;
- case "homepage":
- // TODO: NYI
- break;
case "removed":
var knownSubscription = subscriptionsMap[subscription.url];
getAcceptableAdsURL(function(acceptableAdsUrl)
@@ -1006,8 +1000,8 @@
collections.filterLists.removeItem(knownSubscription);
});
break;
- case "title":
- // TODO: NYI
+ default:
+ updateSubscription(subscription);
break;
}
}
« messageResponder.js ('K') | « messageResponder.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld