Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29339735: Issue 3935 - Force wmode to transparent to enable more flash screenshots

Created:
April 15, 2016, 10:58 a.m. by tschuster
Modified:
Dec. 21, 2017, 10:45 a.m.
Reviewers:
sergei, Wladimir Palant
Visibility:
Public.

Description

Issue 3935 - Force wmode to transparent to enable more flash screenshots

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M run.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6
tschuster
April 15, 2016, 11 a.m. (2016-04-15 11:00:48 UTC) #1
sergei
LGTM
April 15, 2016, 12:03 p.m. (2016-04-15 12:03:02 UTC) #2
Wladimir Palant
LGTM
April 15, 2016, 12:15 p.m. (2016-04-15 12:15:09 UTC) #3
Wladimir Palant
Tom, why is this review still open? Do you still plan to push it? Then ...
Oct. 7, 2016, 12:54 p.m. (2016-10-07 12:54:16 UTC) #4
Wladimir Palant
On 2016/10/07 12:54:16, Wladimir Palant wrote: > Then you should send Sergei the patch. Strike ...
Oct. 7, 2016, 12:55 p.m. (2016-10-07 12:55:07 UTC) #5
tschuster
Oct. 7, 2016, 1:17 p.m. (2016-10-07 13:17:35 UTC) #6
On 2016/10/07 12:55:07, Wladimir Palant wrote:
> On 2016/10/07 12:54:16, Wladimir Palant wrote:
> > Then you should send Sergei the patch.
> 
> Strike that, Sergei cannot push other people's patches - you should send it to
> me.

I can push this, but I am not sure if we actually still need it. I think it
depends on whether we run Firefox on some Linux server without acceleration.

Powered by Google App Engine
This is Rietveld