Issue 3687 - Add experimental support for Safari content blockers

metadata.chrome

Index: metadata.chrome
diff --git a/metadata.chrome b/metadata.chrome
index 52af8bf3cfb28dcb4355a3104cce29be6eda4c39..d7105941fc761ae1db12a97d9f2a6d4ac2f653a5 100644
--- a/metadata.chrome
+++ b/metadata.chrome
@@ -40,3 +40,6 @@ devtools-panel.html = adblockplusui/devtools-panel.html
 devtools-panel.js = adblockplusui/devtools-panel.js
 skin/devtools-panel.css = adblockplusui/skin/devtools-panel.css
 managed-storage-schema.json = chrome/managed-storage-schema.json
+
+[convert_js]
+lib/adblockplus.js -= abp2blocklist/lib/abp2blocklist.js safari/contentBlocking.js

[kzar, 2016/04/19 14:03:49]

I'm guessing there's a better way to achieve the same thing, any suggestions?

[Sebastian Noack, 2016/05/12 11:12:22]

I agree that it's kinda backwards to remove scripts that are only necessary for
one platform in the configuration for another platform. However, since the
convert_js options take some arguments that need to be given in the end, we
cannot append to those options. However, feel free to change the logic in
buildtools to make stuff like this more straight-forward. But how it's currently
implemented this is the only way to do it.

[kzar, 2016/05/17 15:15:36]

Acknowledged. (Considering time constraints I will leave this as-is for now.)

[Sebastian Noack, 2016/05/17 18:35:24]

Feel free to file an issue though. I like the idea, and perhaps it's something
for Jon.

FWIW, I think this would be a more reasonable way to specify the options,
wouldn't insist though:

[convert_js]
lib/adblockplus.js = <input files>
lib/adblockplus.js:module = true 
lib/adblockplus.js:source_repo = https://hg.adblockplus.org/adblockpluscore/

[kzar, 2016/05/17 19:20:21]

There you go https://issues.adblockplus.org/ticket/4047

[Sebastian Noack, 2016/05/18 07:03:29]

Thanks!