Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(390)

Issue 29340588: Issue 3879 - CSS property filters ignore third-party stylesheets in Chrome but not in Firefox (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by Wladimir Palant
Modified:
3 years, 11 months ago
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 3879 - CSS property filters ignore third-party stylesheets in Chrome but not in Firefox Repository: hg.adblockplus.org/adblockpluscore/

Patch Set 1 #

Patch Set 2 : Removed debugging statement #

Total comments: 6

Patch Set 3 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/content/cssProperties.js View 1 2 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
3 years, 11 months ago (2016-04-19 14:32:36 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29340588/diff/29340591/chrome/content/cssProperties.js File chrome/content/cssProperties.js (right): https://codereview.adblockplus.org/29340588/diff/29340591/chrome/content/cssProperties.js#newcode61 chrome/content/cssProperties.js:61: try I guess we should move this logic to ...
3 years, 11 months ago (2016-04-19 14:47:01 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29340588/diff/29340591/chrome/content/cssProperties.js File chrome/content/cssProperties.js (right): https://codereview.adblockplus.org/29340588/diff/29340591/chrome/content/cssProperties.js#newcode61 chrome/content/cssProperties.js:61: try On 2016/04/19 14:47:01, Sebastian Noack wrote: > I ...
3 years, 11 months ago (2016-04-19 15:07:43 UTC) #3
Sebastian Noack
3 years, 11 months ago (2016-04-19 15:10:21 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5