Issue 29340588: Issue 3879 - CSS property filters ignore third-party stylesheets in Chrome but not in Firefox

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29340588: Issue 3879 - CSS property filters ignore third-party stylesheets in Chrome but not in Firefox (Closed)

Created:
April 19, 2016, 2:32 p.m. by Wladimir Palant

Modified:
April 19, 2016, 3:15 p.m.

Reviewers:
Sebastian Noack

Visibility:
Public.

Description

Issue 3879 - CSS property filters ignore third-party stylesheets in Chrome but not in Firefox Repository: hg.adblockplus.org/adblockpluscore/

Patch Set 2 : Removed debugging statement #

Total comments: 6

Patch Set 3 : Addressed comments #

Created: April 19, 2016, 3:06 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -0 lines)			Patch
	M	chrome/content/cssProperties.js	View	1 2	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Sebastian Noack

https://codereview.adblockplus.org/29340588/diff/29340591/chrome/content/cssProperties.js File chrome/content/cssProperties.js (right): https://codereview.adblockplus.org/29340588/diff/29340591/chrome/content/cssProperties.js#newcode61 chrome/content/cssProperties.js:61: try I guess we should move this logic to ...

April 19, 2016, 2:47 p.m. (2016-04-19 14:47:01 UTC) #2

Wladimir Palant

April 19, 2016, 3:07 p.m. (2016-04-19 15:07:43 UTC) #3

LGTM

Expand All Messages | Collapse All Messages