Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/content/cssProperties.js

Issue 29340588: Issue 3879 - CSS property filters ignore third-party stylesheets in Chrome but not in Firefox (Closed)
Patch Set: Created April 19, 2016, 2:32 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/content/cssProperties.js
===================================================================
--- a/chrome/content/cssProperties.js
+++ b/chrome/content/cssProperties.js
@@ -53,16 +53,32 @@ CSSPropertyFilters.prototype = {
styles.push(property + ": " + value + (priority ? " !" + priority : "") + ";");
}
styles.sort();
return styles.join(" ");
},
findSelectors: function(stylesheet, selectors)
{
+ try
+ {
+ // Explicitly ignore third-party stylesheets to ensure consistent behavior
+ // between Firefox and Chrome.
+ if (stylesheet.href &&
+ new URL(stylesheet.href).origin != this.window.location.origin)
+ {
+ return;
+ }
+ }
+ catch (e)
+ {
+ // An invalid URL, can be ignored.
+ Cu.reportError(e);
+ }
+
var rules = stylesheet.cssRules;
if (!rules)
return;
for (var i = 0; i < rules.length; i++)
{
var rule = rules[i];
if (rule.type != rule.STYLE_RULE)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld