Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29340653: Issue 3958 - Fixed initialization race condition when Adblock Plus is updated (Closed)

Created:
April 20, 2016, 1:58 p.m. by Wladimir Palant
Modified:
April 20, 2016, 5:15 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 3958 - Fixed initialization race condition when Adblock Plus is updated Repository: hg.adblockplus.org/adblockplus

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M lib/child/main.js View 1 chunk +14 lines, -6 lines 2 comments Download

Messages

Total messages: 4
Wladimir Palant
April 20, 2016, 1:58 p.m. (2016-04-20 13:58:42 UTC) #1
Thomas Greiner
https://codereview.adblockplus.org/29340653/diff/29340654/lib/child/main.js File lib/child/main.js (right): https://codereview.adblockplus.org/29340653/diff/29340654/lib/child/main.js#newcode23 lib/child/main.js:23: port.emitWithResponse("ping").then(() => Where is the code that responds to ...
April 20, 2016, 2:38 p.m. (2016-04-20 14:38:35 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29340653/diff/29340654/lib/child/main.js File lib/child/main.js (right): https://codereview.adblockplus.org/29340653/diff/29340654/lib/child/main.js#newcode23 lib/child/main.js:23: port.emitWithResponse("ping").then(() => On 2016/04/20 14:38:35, Thomas Greiner wrote: > ...
April 20, 2016, 2:41 p.m. (2016-04-20 14:41:40 UTC) #3
Thomas Greiner
April 20, 2016, 4:57 p.m. (2016-04-20 16:57:53 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld