Issue 3967 - Create directories for mapped files

Issue 3967 - Create directories for mapped files

[kzar, 2016-04-21 15:39:41]

Patch Set 1

[Sebastian Noack, 2016-05-12 12:00:24]

https://codereview.adblockplus.org/29340721/diff/29340722/packager.py
File packager.py (right):

https://codereview.adblockplus.org/29340721/diff/29340722/packager.py#newcode99
packager.py:99: def isIgnored(self, relpath):
Nit: New names should be lowercase.

https://codereview.adblockplus.org/29340721/diff/29340722/packager.py#newcode111
packager.py:111: self.isIncluded(name) and not self.isIgnored(name)):
Nit: The indentation here isn't compliant with PEP-8, and not very readable,
since the last line of the condition is on the same indentation level as the
block body.

One way to fix that would be:

  if name not in skip and (self.isIncluded(name) and not
                           self.isIgnored(name)):

Or alternatively, you could use a temporary variable.

https://codereview.adblockplus.org/29340721/diff/29340722/packager.py#newcode129
packager.py:129: self.includedFiles.add(target.split('/')[0])
Why is it necessary to add it add the directory to includedFiles? It seems if we
just go ahead if the file isn't ignored everything would already work as
intended.