Issue 29340737: Issue 3968 - Add "new-" prefix to option file names

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29340737: Issue 3968 - Add "new-" prefix to option file names (Closed)

Created:
April 22, 2016, 9:21 a.m. by kzar

Modified:
April 22, 2016, 12:40 p.m.

Reviewers:
Thomas Greiner

CC:
Sebastian Noack

Visibility:
Public.

Description

Issue 3968 - Add "new-" prefix to option file names

Patch Set 2 : Updated sentence about firstRun parameters for consistency. #

Created: April 22, 2016, 12:23 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3334 lines)			Patch
M	README.md	View	1	3 chunks	+8 lines, -6 lines	0 comments	Download
M	ext/background.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A +	locale/en-US/new-options.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	locale/en-US/options.json	View		1 chunk	+0 lines, -402 lines	0 comments	Download
A +	new-options.html	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A +	new-options.js	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	options.html	View		1 chunk	+0 lines, -428 lines	0 comments	Download
D	options.js	View		1 chunk	+0 lines, -1166 lines	0 comments	Download
A +	skin/new-options.css	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	skin/options.css	View		1 chunk	+0 lines, -1331 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Thomas Greiner

LGTM, just a minor detail in the README. https://codereview.adblockplus.org/29340737/diff/29340738/README.md File README.md (right): https://codereview.adblockplus.org/29340737/diff/29340738/README.md#newcode79 README.md:79: To ...

April 22, 2016, 12:08 p.m. (2016-04-22 12:08:37 UTC) #2

kzar

April 22, 2016, 12:24 p.m. (2016-04-22 12:24:00 UTC) #3

Patch Set 2 : Updated sentence about firstRun parameters for consistency.

https://codereview.adblockplus.org/29340737/diff/29340738/README.md
File README.md (right):

https://codereview.adblockplus.org/29340737/diff/29340738/README.md#newcode79
README.md:79: To aid testing, the behavior of this page is affected by a number
of URL
On 2016/04/22 12:08:36, Thomas Greiner wrote:
> Detail: This sentence was copied from the first-run page section so it'd be
> great to keep those in sync.

Done.

Expand All Messages | Collapse All Messages