lib/notificationHelper.js - Issue 29340749: Issue 3816 - Add hidden toggle for the new options page

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/notificationHelper.js

Issue 29340749: Issue 3816 - Add hidden toggle for the new options page (Closed)

Patch Set: Update adblockplusui dependency Created April 22, 2016, 12:43 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: lib/notificationHelper.js

diff --git a/lib/notificationHelper.js b/lib/notificationHelper.js

index 4667bc365597dc932e7985d9608290815d13057a..c60b2703aa0b0b130293cee3a002ee9cdd266940 100644

--- a/lib/notificationHelper.js

+++ b/lib/notificationHelper.js

@@ -131,7 +131,7 @@ function notificationButtonClick(buttonIndex)

break;

case "configure":

Prefs.notifications_showui = true;

- ext.showOptions(function(page)

+ ext.showOptions(Prefs["new_options_page"], function(page)

Sebastian Noack 2016/05/12 12:35:20 Besides, duplicating logic, this also has the effe

{

page.sendMessage({

type: "app.respond",

« no previous file with comments | « dependencies ('k') | lib/prefs.js » ('j') | metadata.common » ('J')