Issue 29340749: Issue 3816 - Add hidden toggle for the new options page

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29340749: Issue 3816 - Add hidden toggle for the new options page (Closed)

Created:
April 22, 2016, 9:32 a.m. by kzar

Modified:
Nov. 17, 2016, 11:40 a.m.

Reviewers:
Sebastian Noack

CC:
Thomas Greiner

Visibility:
Public.

Description

Issue 3816 - Add hidden toggle for the new options page (Depends on changes in https://codereview.adblockplus.org/29340737/ and the dependencies file will obviously need to be updated.)

Patch Set 1 #

Patch Set 2 : Update adblockplusui dependency #

Total comments: 3

Created: April 22, 2016, 12:43 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -7 lines)			Patch
M	chrome/ext/background.js	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	dependencies	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/notificationHelper.js	View		1 chunk	+1 line, -1 line	1 comment	Download
M	lib/prefs.js	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	metadata.common	View		2 chunks	+12 lines, -0 lines	2 comments	Download
M	popup.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	safari/ext/background.js	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Sebastian Noack

May 12, 2016, 12:35 p.m. (2016-05-12 12:35:21 UTC) #3

https://codereview.adblockplus.org/29340749/diff/29340785/lib/notificationHel...
File lib/notificationHelper.js (right):

https://codereview.adblockplus.org/29340749/diff/29340785/lib/notificationHel...
lib/notificationHelper.js:134: ext.showOptions(Prefs["new_options_page"],
function(page)
Besides, duplicating logic, this also has the effect that when bringing up the
options page through the Chrome UI, you'd still always get the old options page.

In order to solve this we could instead make the old options page redirect to
new-options.html. This will keep the logic in one place, and works regardless
how the options page is brought up. The only downside is that you cannot open
the old and new options page side by side then. However, if that is necessary,
it can be worked around by supporting a query string parameter that if given
will bypass the redirect.

https://codereview.adblockplus.org/29340749/diff/29340785/metadata.common
File metadata.common (right):

https://codereview.adblockplus.org/29340749/diff/29340785/metadata.common#new...
metadata.common:72: skin/new-options.css = adblockplusui/skin/new-options.css
Nit: Put this mapping below new-options.js to have all skin/* mappings grouped
together.

https://codereview.adblockplus.org/29340749/diff/29340785/metadata.common#new...
metadata.common:161: adblockplusui/locale/*/new-options.json = =*
You also need common.json for the human readable title of subscriptions like
EasyPrivacy, Malwarelist, etc.

Expand All Messages | Collapse All Messages