Issue 3993 - Implement Utils.yield() in a better way (ABP/Firefox part)

lib/io.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 112 matching lines @@
 
       let onSuccess = function()
       {
         if (processing)
         {
           // Still processing data, delay processing this event.
           loaded = true;
           return;
         }
 
+        // We are ignoring return value of listener.process() here because
+        // turning this callback into a generator would be complicated, and
+        // delaying isn't really necessary for the last two calls.
         if (buffer !== "")
           listener.process(buffer);
         listener.process(null);

[Wladimir Palant, 2016/04/26 18:52:56]

Note that return value is ignored here - turning onSuccess into a generator is
complicated, and delaying isn't really necessary for these final two calls.

[Erik, 2016/04/28 00:51:48]

worth adding a comment for I think, which says what you have above.

[Wladimir Palant, 2016/04/28 12:18:34]

Done.

 
         callback(null);
       };
 
       let onError = function(e)
       {
         if (processing)
         {
           // Still processing data, delay processing this event.
           error = e;
@@ skipping 113 matching lines @@
     }
   },
 
   /**
    * Renames a file within the same directory, will call callback when done.
    */
   renameFile: function(/**nsIFile*/ fromFile, /**String*/ newName, /**Function*/ callback)
   {
     try
     {
-      toFile = fromFile.clone();
+      let toFile = fromFile.clone();
       toFile.leafName = newName;
       let promise = OS.File.move(fromFile.path, toFile.path);
       promise.then(callback.bind(null, null), callback);
     }
     catch(e)
     {
       callback(e);
     }
   },
 
@@ skipping 43 matching lines @@
         else
           callback(e);
       });
     }
     catch(e)
     {
       callback(e);
     }
   }
 }