Issue 3993 - Implement Utils.yield() in a better way (ABP/Firefox part)

Issue 3993 - Implement Utils.yield() in a better way (ABP/Firefox part)

The other part is under https://codereview.adblockplus.org/29340849/.

Repository: hg.adblockplus.org/adblockplus

[Wladimir Palant, 2016-04-26 18:52:56]

https://codereview.adblockplus.org/29340852/diff/29340853/dependencies
File dependencies (right):

https://codereview.adblockplus.org/29340852/diff/29340853/dependencies#newcode4
dependencies:4: adblockpluscore = adblockpluscore hg:8eaa5ae95fc0 git:???????
This depends on https://codereview.adblockplus.org/29340849/, the revision IDs
will be final once that change lands.

https://codereview.adblockplus.org/29340852/diff/29340853/lib/io.js
File lib/io.js (right):

https://codereview.adblockplus.org/29340852/diff/29340853/lib/io.js#newcode135
lib/io.js:135: listener.process(null);
Note that return value is ignored here - turning onSuccess into a generator is
complicated, and delaying isn't really necessary for these final two calls.

[Erik, 2016-04-28 00:51:37]

On 2016/04/26 18:52:56, Wladimir Palant wrote:
> https://codereview.adblockplus.org/29340852/diff/29340853/dependencies
> File dependencies (right):
> 
>
https://codereview.adblockplus.org/29340852/diff/29340853/dependencies#newcode4
> dependencies:4: adblockpluscore = adblockpluscore hg:8eaa5ae95fc0 git:???????
> This depends on https://codereview.adblockplus.org/29340849/, the revision IDs
> will be final once that change lands.
> 
> https://codereview.adblockplus.org/29340852/diff/29340853/lib/io.js
> File lib/io.js (right):
> 
> https://codereview.adblockplus.org/29340852/diff/29340853/lib/io.js#newcode135
> lib/io.js:135: listener.process(null);
> Note that return value is ignored here - turning onSuccess into a generator is
> complicated, and delaying isn't really necessary for these final two calls.

LGTM!

[Erik, 2016-04-28 00:51:48]

https://codereview.adblockplus.org/29340852/diff/29340853/lib/io.js
File lib/io.js (right):

https://codereview.adblockplus.org/29340852/diff/29340853/lib/io.js#newcode135
lib/io.js:135: listener.process(null);
On 2016/04/26 18:52:56, Wladimir Palant wrote:
> Note that return value is ignored here - turning onSuccess into a generator is
> complicated, and delaying isn't really necessary for these final two calls.

worth adding a comment for I think, which says what you have above.

[Wladimir Palant, 2016-04-28 12:18:34]

https://codereview.adblockplus.org/29340852/diff/29340853/lib/io.js
File lib/io.js (right):

https://codereview.adblockplus.org/29340852/diff/29340853/lib/io.js#newcode135
lib/io.js:135: listener.process(null);
On 2016/04/28 00:51:48, Erik wrote:
> On 2016/04/26 18:52:56, Wladimir Palant wrote:
> > Note that return value is ignored here - turning onSuccess into a generator
is
> > complicated, and delaying isn't really necessary for these final two calls.
> 
> worth adding a comment for I think, which says what you have above.

Done.