Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29340888: Noissue - Make markup compatible with the new version of Markdown's attr_list extension (Closed)

Created:
April 27, 2016, 3:29 p.m. by Wladimir Palant
Modified:
April 27, 2016, 3:40 p.m.
Visibility:
Public.

Description

Noissue - Make markup compatible with the new version of Markdown's attr_list extension Repository: hg.adblockplus.org/web.eyeo.com

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M includes/contact/address.md View 1 chunk +1 line, -1 line 0 comments Download
M includes/contact/details.md View 1 chunk +3 lines, -4 lines 2 comments Download
M includes/index/media.md View 1 chunk +1 line, -1 line 0 comments Download
M includes/index/mission.md View 1 chunk +1 line, -1 line 0 comments Download
M includes/index/whoweare.md View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Wladimir Palant
April 27, 2016, 3:29 p.m. (2016-04-27 15:29:23 UTC) #1
Thomas Greiner
LGTM, just a minor coding style issue https://codereview.adblockplus.org/29340888/diff/29340889/includes/contact/details.md File includes/contact/details.md (left): https://codereview.adblockplus.org/29340888/diff/29340889/includes/contact/details.md#oldcode17 includes/contact/details.md:17: Coding style: ...
April 27, 2016, 3:32 p.m. (2016-04-27 15:32:18 UTC) #2
saroyanm
LGTM
April 27, 2016, 3:38 p.m. (2016-04-27 15:38:56 UTC) #3
Wladimir Palant
April 27, 2016, 3:39 p.m. (2016-04-27 15:39:18 UTC) #4
https://codereview.adblockplus.org/29340888/diff/29340889/includes/contact/de...
File includes/contact/details.md (left):

https://codereview.adblockplus.org/29340888/diff/29340889/includes/contact/de...
includes/contact/details.md:17: 
On 2016/04/27 15:32:18, Thomas Greiner wrote:
> Coding style: "Newline at end of file, otherwise no trailing whitespace."

Yes, this file had two newlines at the end of file. My editor corrected this
automatically.

Powered by Google App Engine
This is Rietveld