Noissue - Added flake8-abp and pep8-naming extension and fix reported warnings

Noissue - Added flake8-abp and pep8-naming extension and fix reported warnings

[Sebastian Noack, 2016-05-12 14:47:24]

https://codereview.adblockplus.org/29341320/diff/29341321/abp/filters/render_...
File abp/filters/render_script.py (left):

https://codereview.adblockplus.org/29341320/diff/29341321/abp/filters/render_...
abp/filters/render_script.py:60: out_fp.write(line.to_string() + '\n')
This will fail now if line.to_string() returns a byte string. But all tests
pass, so it seems we are fine, assuming there is sufficient test coverage.

[Vasily Kuznetsov, 2016-05-12 15:22:23]

LGTM

https://codereview.adblockplus.org/29341320/diff/29341321/abp/filters/render_...
File abp/filters/render_script.py (left):

https://codereview.adblockplus.org/29341320/diff/29341321/abp/filters/render_...
abp/filters/render_script.py:60: out_fp.write(line.to_string() + '\n')
On 2016/05/12 14:47:24, Sebastian Noack wrote:
> This will fail now if line.to_string() returns a byte string. But all tests
> pass, so it seems we are fine, assuming there is sufficient test coverage.

line.to_string() is supposed to always return unicode, so I think we're good.

[Sebastian Noack, 2016-05-12 15:31:03]

https://codereview.adblockplus.org/29341320/diff/29341335/tests/test_render_s...
File tests/test_render_script.py (right):

https://codereview.adblockplus.org/29341320/diff/29341335/tests/test_render_s...
tests/test_render_script.py:46: u'[Adblock]\n\u1234'.encode('utf-8'), mode='wb')
Since, for whatever reason, the qa env did run with Python 3 for me I didn't
spotted those: '\u1234' is the same as '\\u1234' since \u has no meaning in
non-unicode strings, hence the backslash is just interpreted as backslash and
the literal doesn't match repr() anymore. So this isn't only against our coding
style, but also rendered this test useless on Python 2. ;)

[Sebastian Noack, 2016-05-27 12:54:55]

https://codereview.adblockplus.org/29341320/diff/29341335/tests/test_render_s...
File tests/test_render_script.py (right):

https://codereview.adblockplus.org/29341320/diff/29341335/tests/test_render_s...
tests/test_render_script.py:46: u'[Adblock]\n\u1234'.encode('utf-8'), mode='wb')
On 2016/05/12 15:31:03, Sebastian Noack wrote:
> Since, for whatever reason, the qa env did run with Python 3 for me I didn't
> spotted those: '\u1234' is the same as '\\u1234' since \u has no meaning in
> non-unicode strings, hence the backslash is just interpreted as backslash and
> the literal doesn't match repr() anymore. So this isn't only against our
coding
> style, but also rendered this test useless on Python 2. ;)

I reverted changes of patch set 2. My conclusion above is wrong, as this file
uses "from __future__ import unicode_literals" which flake8-abp is going to
account for with issue 4404.

[Vasily Kuznetsov, 2016-05-27 13:22:49]

LGTM