Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29342909: Issue 4020 - In Edge, rawSender.url is not always defined (Closed)

Created:
May 23, 2016, 5:45 a.m. by Oleksandr
Modified:
May 30, 2016, 12:51 p.m.
Reviewers:
Sebastian Noack
CC:
kzar
Visibility:
Public.

Description

Issue 4020 - In Edge, rawSender.url is not always defined

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use null instead of an empty string. Add a description comment. #

Total comments: 1

Patch Set 3 : Add space before the column #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/ext/background.js View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6
Oleksandr
May 23, 2016, 5:46 a.m. (2016-05-23 05:46:41 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29342909/diff/29342910/chrome/ext/background.js File chrome/ext/background.js (right): https://codereview.adblockplus.org/29342909/diff/29342910/chrome/ext/background.js#newcode504 chrome/ext/background.js:504: url: rawSender.url ? new URL(rawSender.url): '', I think it ...
May 27, 2016, 11:58 a.m. (2016-05-27 11:58:47 UTC) #2
Oleksandr
May 28, 2016, 10:29 p.m. (2016-05-28 22:29:34 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29342909/diff/29345216/chrome/ext/background.js File chrome/ext/background.js (right): https://codereview.adblockplus.org/29342909/diff/29345216/chrome/ext/background.js#newcode506 chrome/ext/background.js:506: url: rawSender.url ? new URL(rawSender.url): null, Nit: Please add ...
May 29, 2016, 1:53 p.m. (2016-05-29 13:53:59 UTC) #4
Oleksandr
May 30, 2016, 12:35 p.m. (2016-05-30 12:35:25 UTC) #5
Sebastian Noack
May 30, 2016, 12:36 p.m. (2016-05-30 12:36:36 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld