Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29342955: Issue 3985 - Unified test runner for sitescripts (Closed)

Created:
May 23, 2016, 9:50 p.m. by Vasily Kuznetsov
Modified:
May 25, 2016, 8:29 p.m.
Reviewers:
Sebastian Noack
CC:
mathias
Visibility:
Public.

Description

I configured tox to run the part of the tests that doesn't need anything not covered by tox/pip and added a Vagrantfile that allows to run the rest of the tests too. Everything is documented in the README.

Patch Set 1 #

Total comments: 10

Patch Set 2 : Remove filterhits, remove dependencies for notifications tests, make everything run in one environm… #

Total comments: 4

Patch Set 3 : Add flake8 checking, import some of the web handlers into tests instead of none, switch to pysed fr… #

Patch Set 4 : Measure test coverage of everything in sitescripts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -1 line) Patch
M .gitignore View 1 1 chunk +5 lines, -1 line 0 comments Download
M .hgignore View 1 1 chunk +4 lines, -0 lines 0 comments Download
M README.md View 1 1 chunk +9 lines, -0 lines 0 comments Download
A tox.ini View 1 2 3 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 7
Vasily Kuznetsov
May 23, 2016, 9:56 p.m. (2016-05-23 21:56:21 UTC) #1
mathias
Quite promising, but IMHO there is a step missing in the concept, namely some sort ...
May 23, 2016, 10:25 p.m. (2016-05-23 22:25:33 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29342955/diff/29342956/README.md File README.md (right): https://codereview.adblockplus.org/29342955/diff/29342956/README.md#newcode97 README.md:97: The tests dependent on the database are covering the ...
May 24, 2016, 7:58 a.m. (2016-05-24 07:58:37 UTC) #3
Vasily Kuznetsov
Since we're getting rid of `filterhits`, I excluded its tests from the configuration. I also ...
May 24, 2016, 6:15 p.m. (2016-05-24 18:15:36 UTC) #4
Sebastian Noack
Good job. That is much better. Also mind updating the issue? And any reason why ...
May 25, 2016, 7:51 a.m. (2016-05-25 07:51:36 UTC) #5
Vasily Kuznetsov
https://codereview.adblockplus.org/29342955/diff/29343014/tox.ini File tox.ini (right): https://codereview.adblockplus.org/29342955/diff/29343014/tox.ini#newcode27 tox.ini:27: bash -c "sed -e 's/sitescripts\.[a-zA-Z_]*\.web.*/# &/' .sitescripts.example >.sitescripts.test" On ...
May 25, 2016, 3:17 p.m. (2016-05-25 15:17:41 UTC) #6
Sebastian Noack
May 25, 2016, 7:17 p.m. (2016-05-25 19:17:44 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld