Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29344540: Issue 3675 - Add some tests for ContentBlockerList (Closed)

Created:
May 25, 2016, 4:18 p.m. by kzar
Modified:
May 26, 2016, 8:22 a.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 3675 - Add some tests for ContentBlockerList

Patch Set 1 #

Total comments: 6

Patch Set 2 : Removed #4072 fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -0 lines) Patch
M README.md View 1 chunk +9 lines, -0 lines 0 comments Download
M package.json View 1 chunk +6 lines, -0 lines 0 comments Download
A test/abp2blocklist.js View 1 chunk +216 lines, -0 lines 0 comments Download

Messages

Total messages: 4
kzar
Patch Set 1 https://codereview.adblockplus.org/29344540/diff/29344541/lib/abp2blocklist.js File lib/abp2blocklist.js (right): https://codereview.adblockplus.org/29344540/diff/29344541/lib/abp2blocklist.js#newcode252 lib/abp2blocklist.js:252: if (!(filter.contentType & whitelistableRequestTypes)) Fixed this ...
May 25, 2016, 4:20 p.m. (2016-05-25 16:20:54 UTC) #1
Sebastian Noack
Awesome, finnally tests. The code looks good too. https://codereview.adblockplus.org/29344540/diff/29344541/lib/abp2blocklist.js File lib/abp2blocklist.js (right): https://codereview.adblockplus.org/29344540/diff/29344541/lib/abp2blocklist.js#newcode252 lib/abp2blocklist.js:252: if ...
May 25, 2016, 5:16 p.m. (2016-05-25 17:16:33 UTC) #2
kzar
Patch Set 2 : Removed #4072 fix https://codereview.adblockplus.org/29344540/diff/29344541/lib/abp2blocklist.js File lib/abp2blocklist.js (right): https://codereview.adblockplus.org/29344540/diff/29344541/lib/abp2blocklist.js#newcode252 lib/abp2blocklist.js:252: if (!(filter.contentType ...
May 25, 2016, 6:31 p.m. (2016-05-25 18:31:55 UTC) #3
Sebastian Noack
May 26, 2016, 12:34 a.m. (2016-05-26 00:34:18 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld