Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/abp2blocklist.js

Issue 29344540: Issue 3675 - Add some tests for ContentBlockerList (Closed)
Patch Set: Created May 25, 2016, 4:18 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « README.md ('k') | package.json » ('j') | package.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/abp2blocklist.js
diff --git a/lib/abp2blocklist.js b/lib/abp2blocklist.js
index fb90da33463b453806cae4fa5497cb31cef9223c..aa074f5acfaac19b5552a72d8b942b66198441a9 100644
--- a/lib/abp2blocklist.js
+++ b/lib/abp2blocklist.js
@@ -249,7 +249,7 @@ function convertFilterAddRules(rules, filter, action, withResourceTypes)
});
// If the filter contains other supported options we'll need to generate
// further rules for it, but if not we can simply return now.
- if (!(filter.contentType | whitelistableRequestTypes))
+ if (!(filter.contentType & whitelistableRequestTypes))
kzar 2016/05/25 16:20:54 Fixed this bug in the process of writing the tests
Sebastian Noack 2016/05/25 17:16:33 Awesome, but how will that fix ever be tested, or
kzar 2016/05/25 18:31:54 Good point, created this issue https://issues.adbl
return;
}
« no previous file with comments | « README.md ('k') | package.json » ('j') | package.json » ('J')

Powered by Google App Engine
This is Rietveld