Issue 4070 - Correctly handle multiline commit messages in the mercurial hook

Issue 4070 - Correctly handle multiline commit messages in the mercurial hook

[kzar, 2016-05-25 18:40:18]

https://codereview.adblockplus.org/29344546/diff/29344547/sitescripts/hg/bin/...
File sitescripts/hg/bin/update_issues.py (right):

https://codereview.adblockplus.org/29344546/diff/29344547/sitescripts/hg/bin/...
sitescripts/hg/bin/update_issues.py:72: lines = change.description().split('\n')
Is it possible for people to use DOS style CR+LF newlines in commit messages?

https://codereview.adblockplus.org/29344546/diff/29344547/sitescripts/hg/bin/...
sitescripts/hg/bin/update_issues.py:76: if message.endswith('.'):
IMHO if the first line ends with a "." then we should leave it alone instead of
adding the ellipses.

[kzar, 2016-05-26 08:14:10]

https://codereview.adblockplus.org/29344546/diff/29344547/sitescripts/hg/bin/...
File sitescripts/hg/bin/update_issues.py (right):

https://codereview.adblockplus.org/29344546/diff/29344547/sitescripts/hg/bin/...
sitescripts/hg/bin/update_issues.py:76: if message.endswith('.'):
On 2016/05/25 18:40:18, kzar wrote:
> IMHO if the first line ends with a "." then we should leave it alone instead
of
> adding the ellipses.

(We discussed this in IRC, I didn't realise that there was supposed to be a
blank line after the title before a longer commit message. This logic makes more
sense to me now.)

[Vasily Kuznetsov, 2016-05-26 09:23:17]

https://codereview.adblockplus.org/29344546/diff/29344547/sitescripts/hg/bin/...
File sitescripts/hg/bin/update_issues.py (right):

https://codereview.adblockplus.org/29344546/diff/29344547/sitescripts/hg/bin/...
sitescripts/hg/bin/update_issues.py:72: lines = change.description().split('\n')
On 2016/05/25 18:40:18, kzar wrote:
> Is it possible for people to use DOS style CR+LF newlines in commit messages?

Not sure, but better safe then sorry. Done

https://codereview.adblockplus.org/29344546/diff/29344547/sitescripts/hg/bin/...
sitescripts/hg/bin/update_issues.py:76: if message.endswith('.'):
On 2016/05/26 08:14:10, kzar wrote:
> On 2016/05/25 18:40:18, kzar wrote:
> > IMHO if the first line ends with a "." then we should leave it alone instead
> of
> > adding the ellipses.
> 
> (We discussed this in IRC, I didn't realise that there was supposed to be a
> blank line after the title before a longer commit message. This logic makes
more
> sense to me now.)

Acknowledged.

[kzar, 2016-05-26 09:56:58]

LGTM

Sebastian you want to check this too?

[Sebastian Noack, 2016-05-26 10:44:07]

https://codereview.adblockplus.org/29344546/diff/29344568/sitescripts/hg/bin/...
File sitescripts/hg/bin/update_issues.py (right):

https://codereview.adblockplus.org/29344546/diff/29344568/sitescripts/hg/bin/...
sitescripts/hg/bin/update_issues.py:76: if message.endswith('.'):
This check seems redundant.

[Vasily Kuznetsov, 2016-05-26 19:34:01]

https://codereview.adblockplus.org/29344546/diff/29344568/sitescripts/hg/bin/...
File sitescripts/hg/bin/update_issues.py (right):

https://codereview.adblockplus.org/29344546/diff/29344568/sitescripts/hg/bin/...
sitescripts/hg/bin/update_issues.py:76: if message.endswith('.'):
On 2016/05/26 10:44:07, Sebastian Noack wrote:
> This check seems redundant.

Indeed. Done.

[Sebastian Noack, 2016-05-26 19:45:41]

LGTM