Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29345109: Issue 4059 - Adapt the manifest for Edge (2) (Closed)

Created:
May 28, 2016, 8:06 a.m. by Oleksandr
Modified:
May 28, 2016, 11:03 p.m.
Reviewers:
Sebastian Noack
CC:
kzar
Visibility:
Public.

Description

Issue 4059 - Adapt the manifest for Edge (2)

Patch Set 1 #

Patch Set 2 : Move 'author' to metadata.common #

Patch Set 3 : Fix the diff not to be incremental #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M metadata.common View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M metadata.safari View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
Oleksandr
May 28, 2016, 8:07 a.m. (2016-05-28 08:07:11 UTC) #1
Sebastian Noack
We already have the author in metadata.safari. So since we need it for both build ...
May 28, 2016, 8:13 a.m. (2016-05-28 08:13:06 UTC) #2
Oleksandr
May 28, 2016, 9:08 a.m. (2016-05-28 09:08:13 UTC) #3
Sebastian Noack
LGTM Note that this needs to land in upstream before the buildtools changes are pushed. ...
May 28, 2016, 9:48 a.m. (2016-05-28 09:48:56 UTC) #4
Oleksandr
May 28, 2016, 11:02 p.m. (2016-05-28 23:02:32 UTC) #5
Uploaded a full diff. Not sure how the previous one got incremental, sorry.

Powered by Google App Engine
This is Rietveld