messageResponder.js - Issue 29345232: Issue 4084 - Do not use @@bidi_dir directly in adblockplusui

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: messageResponder.js

Issue 29345232: Issue 4084 - Do not use @@bidi_dir directly in adblockplusui (Closed)

Patch Set: Also adapt the mock implementation Created May 30, 2016, 1:58 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: messageResponder.js

diff --git a/messageResponder.js b/messageResponder.js

index dab496354b91789337171c43f9d1e73f66ca7a85..de494eef809628f4c99cd5243f2b01a3ef77ec32 100644

--- a/messageResponder.js

+++ b/messageResponder.js

@@ -181,7 +181,7 @@

if ("chromeRegistry" in Utils)

bidiDir = Utils.chromeRegistry.isLocaleRTL("adblockplus") ? "rtl" : "ltr";

else

- bidiDir = ext.i18n.getMessage("@@bidi_dir");

+ bidiDir = Utils.readingDirection;

Sebastian Noack 2016/05/30 14:16:57 I guess we should move the logic for @@bidi_dir an

callback({locale: Utils.appLocale, bidiDir: bidiDir});

}

« no previous file with comments | « background.js ('k') | no next file » | no next file with comments »