Issue 4090 - Make require() load modules lazily

This is missing dependency update, will add it once #4088 lands.

Repository: hg.adblockplus.org/adblockpluschrome

[Sebastian Noack, 2016-05-31 11:42:13]

https://codereview.adblockplus.org/29345407/diff/29345408/background.js
File background.js (right):

https://codereview.adblockplus.org/29345407/diff/29345408/background.js#newco...
background.js:18: // Make sure that the required modules get loaded
As you might have realized this file has shrinked a lot, and is eventually
matter to be go away, with all code encapsulated in modules. So I wonder whether
we can have a different mechanism, perhaps an option in jsHydra, to force load
modules?

[Sebastian Noack, 2016-05-31 11:44:27]

https://codereview.adblockplus.org/29345407/diff/29345408/lib/compat.js
File lib/compat.js (right):

https://codereview.adblockplus.org/29345407/diff/29345408/lib/compat.js#newco...
lib/compat.js:25: if (typeof result == "function" && !(module in
require.loaded))
Where is it actually added to require.loaded?

[Wladimir Palant, 2016-05-31 13:47:55]

https://codereview.adblockplus.org/29345407/diff/29345408/background.js
File background.js (right):

https://codereview.adblockplus.org/29345407/diff/29345408/background.js#newco...
background.js:18: // Make sure that the required modules get loaded
On 2016/05/31 11:42:13, Sebastian Noack wrote:
> As you might have realized this file has shrinked a lot, and is eventually
> matter to be go away, with all code encapsulated in modules. So I wonder
whether
> we can have a different mechanism, perhaps an option in jsHydra, to force load
> modules?

Ok, I've implemented it as an option in JSHydra. This doesn't seem to be the
cleanest solution however. Usually, there is a dedicated entry point ("main"
module in Firefox) that will load all the other modules.

https://codereview.adblockplus.org/29345407/diff/29345408/lib/compat.js
File lib/compat.js (right):

https://codereview.adblockplus.org/29345407/diff/29345408/lib/compat.js#newco...
lib/compat.js:25: if (typeof result == "function" && !(module in
require.loaded))
On 2016/05/31 11:44:27, Sebastian Noack wrote:
> Where is it actually added to require.loaded?

I probably should have tested this code path :)

It's not really used due to none of our modules returning functions. But I fixed
this issue and this time I also made sure to test it properly.

https://codereview.adblockplus.org/29345407/diff/29345414/metadata.common
File metadata.common (right):

https://codereview.adblockplus.org/29345407/diff/29345414/metadata.common#new...
metadata.common:104: adblockpluscore/lib/synchronizer.js
The list above is still identical, merely sorted alphabetically - the ordering
no longer matters.

https://codereview.adblockplus.org/29345407/diff/29345414/metadata.common#new...
metadata.common:106:
autoload=filterListener,synchronizer,requestBlocker,popupBlocker,contentBlocking,subscriptionInit,filterComposer,stats,uninstall
It seems that adblockpluschrome has a rather significant list of modules that
expect to load automatically. I verified that the only module not loading on
startup is filterValidation - this one is actually loaded on demand.

[kzar, 2016-05-31 14:54:09]

LGTM

https://codereview.adblockplus.org/29345407/diff/29345408/background.js
File background.js (right):

https://codereview.adblockplus.org/29345407/diff/29345408/background.js#newco...
background.js:18: // Make sure that the required modules get loaded
On 2016/05/31 13:47:54, Wladimir Palant wrote:
> On 2016/05/31 11:42:13, Sebastian Noack wrote:
> > As you might have realized this file has shrinked a lot, and is eventually
> > matter to be go away, with all code encapsulated in modules. So I wonder
> whether
> > we can have a different mechanism, perhaps an option in jsHydra, to force
load
> > modules?
> 
> Ok, I've implemented it as an option in JSHydra. This doesn't seem to be the
> cleanest solution however. Usually, there is a dedicated entry point ("main"
> module in Firefox) that will load all the other modules.

The new approach makes sense to me, but the only thing is it might make
https://issues.adblockplus.org/ticket/4047 more urgent.

https://codereview.adblockplus.org/29345407/diff/29345414/metadata.common
File metadata.common (right):

https://codereview.adblockplus.org/29345407/diff/29345414/metadata.common#new...
metadata.common:104: adblockpluscore/lib/synchronizer.js
On 2016/05/31 13:47:55, Wladimir Palant wrote:
> The list above is still identical, merely sorted alphabetically - the ordering
> no longer matters.

Acknowledged.

[Wladimir Palant, 2016-05-31 15:13:44]

The buildtools changes landed so I've uploaded the final patch now, with the
dependency update. The side-effect is that ensure_dependencies.py has been
updated as well.

[kzar, 2016-05-31 15:16:24]

LGTM