Unified Diff: build.py
Issue 29345505:
Issue 4099 - Don't enforce Gecko build IDs to be numerical (Closed)
Patch Set: Removed unnecessary type conversion
Created June 1, 2016, 5:16 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
packager.py » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: build.py |
| =================================================================== |
| --- a/build.py |
| +++ b/build.py |
| @@ -180,17 +180,19 @@ def runBuild(baseDir, scriptName, opts, |
| buildNum = None |
| multicompartment = False |
| releaseBuild = False |
| keyFile = None |
| for option, value in opts: |
| if option in ('-l', '--locales'): |
| locales = value.split(',') |
| elif option in ('-b', '--build'): |
| - buildNum = int(value) |
| + buildNum = value |
| + if type != 'gecko' and not re.search(r'^\d+$', buildNum): |
| + raise TypeError('Build number must be numerical') |
| elif option in ('-k', '--key'): |
| keyFile = value |
| elif option in ('-m', '--multi-compartment'): |
| multicompartment = True |
| elif option in ('-r', '--release'): |
| releaseBuild = True |
| outFile = args[0] if len(args) > 0 else None |
« no previous file with comments
|
« no previous file
|
packager.py » ('j')
|
no next file with comments »
