Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: packager.py

Issue 29345505: Issue 4099 - Don't enforce Gecko build IDs to be numerical (Closed)
Patch Set: Removed unnecessary type conversion Created June 1, 2016, 5:16 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packager.py
===================================================================
--- a/packager.py
+++ b/packager.py
@@ -52,17 +52,16 @@ def getBuildNum(baseDir):
return '0'
def getBuildVersion(baseDir, metadata, releaseBuild, buildNum=None):
version = metadata.get('general', 'version')
if not releaseBuild:
if buildNum == None:
buildNum = getBuildNum(baseDir)
- buildNum = str(buildNum)
if len(buildNum) > 0:
if re.search(r'(^|\.)\d+$', version):
# Numerical version number - need to fill up with zeros to have three
# version components.
while version.count('.') < 2:
version += '.0'
version += '.' + buildNum
return version
« no previous file with comments | « build.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld