Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(131)

Issue 29345737: Issue 4146 - Fix failing UpdateCheckTest.testApplicationUpdateAvailable test in libadblockplus-andr… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 3 months ago by anton
Modified:
3 years ago
CC:
René Jeschke
Visibility:
Public.

Description

Issue 4146 - Fix failing UpdateCheckTest.testApplicationUpdateAvailable test in libadblockplus-andr… #depends on https://codereview.adblockplus.org/29344967/

Patch Set 1 #

Patch Set 2 : moved entry points to JniLibrary.cpp #

Total comments: 11

Patch Set 3 : codestyle, moved unload #

Total comments: 2

Patch Set 4 : using jni version define from Utils.h #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -24 lines) Patch
M libadblockplus-android/jni/Android.mk View 1 1 chunk +2 lines, -1 line 0 comments Download
M libadblockplus-android/jni/JniJsValue.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M libadblockplus-android/jni/JniJsValue.cpp View 1 2 2 chunks +22 lines, -10 lines 0 comments Download
A + libadblockplus-android/jni/JniLibrary.cpp View 1 2 3 1 chunk +17 lines, -13 lines 1 comment Download

Messages

Total messages: 14
anton
This happens because new thread is created and it's neither attached not jclass references are ...
3 years, 3 months ago (2016-06-10 13:44:42 UTC) #1
diegocarloslima
On 2016/06/10 13:44:42, anton wrote: > This happens because new thread is created and it's ...
3 years ago (2016-09-08 19:39:40 UTC) #2
anton
On 2016/09/08 19:39:40, diegocarloslima wrote: > On 2016/06/10 13:44:42, anton wrote: > > This happens ...
3 years ago (2016-09-14 07:42:08 UTC) #3
diegocarloslima
On 2016/09/14 07:42:08, anton wrote: > On 2016/09/08 19:39:40, diegocarloslima wrote: > > On 2016/06/10 ...
3 years ago (2016-09-14 22:55:51 UTC) #4
Felix Dahlke
Looks good, I just have some nits and one question. And also a more general ...
3 years ago (2016-09-15 13:01:20 UTC) #5
anton
https://codereview.adblockplus.org/29345737/diff/29352965/libadblockplus-android/jni/JniJsValue.cpp File libadblockplus-android/jni/JniJsValue.cpp (right): https://codereview.adblockplus.org/29345737/diff/29352965/libadblockplus-android/jni/JniJsValue.cpp#newcode227 libadblockplus-android/jni/JniJsValue.cpp:227: void JniJsValue_OnUnload(JavaVM *vm, JNIEnv *env, void *reserved) On 2016/09/15 ...
3 years ago (2016-09-15 13:18:12 UTC) #6
anton
https://codereview.adblockplus.org/29345737/diff/29352965/libadblockplus-android/jni/JniJsValue.h File libadblockplus-android/jni/JniJsValue.h (right): https://codereview.adblockplus.org/29345737/diff/29352965/libadblockplus-android/jni/JniJsValue.h#newcode34 libadblockplus-android/jni/JniJsValue.h:34: void JniJsValue_OnUnload(JavaVM *vm, JNIEnv *env, void *reserved); On 2016/09/15 ...
3 years ago (2016-09-15 13:28:18 UTC) #7
Felix Dahlke
Just one thing now. But have you noticed my general question about whether we should ...
3 years ago (2016-09-15 15:05:56 UTC) #8
anton
On 2016/09/15 13:01:20, Felix Dahlke wrote: > Looks good, I just have some nits and ...
3 years ago (2016-09-16 05:48:35 UTC) #9
anton
https://codereview.adblockplus.org/29345737/diff/29353141/libadblockplus-android/jni/JniLibrary.cpp File libadblockplus-android/jni/JniLibrary.cpp (right): https://codereview.adblockplus.org/29345737/diff/29353141/libadblockplus-android/jni/JniLibrary.cpp#newcode20 libadblockplus-android/jni/JniLibrary.cpp:20: #define JNI_REQUIRED_VERSION (JNI_VERSION_1_6) On 2016/09/15 15:05:56, Felix Dahlke wrote: ...
3 years ago (2016-09-16 05:48:45 UTC) #10
Felix Dahlke
On 2016/09/16 05:48:35, anton wrote: > On 2016/09/15 13:01:20, Felix Dahlke wrote: > > Looks ...
3 years ago (2016-09-16 06:12:52 UTC) #11
anton
On 2016/09/16 06:12:52, Felix Dahlke wrote: > On 2016/09/16 05:48:35, anton wrote: > > On ...
3 years ago (2016-09-16 06:23:11 UTC) #12
Felix Dahlke
Great, LGTM!
3 years ago (2016-09-16 07:58:46 UTC) #13
anton
3 years ago (2016-09-16 11:06:04 UTC) #14
https://codereview.adblockplus.org/29345737/diff/29353257/libadblockplus-andr...
File libadblockplus-android/jni/JniLibrary.cpp (right):

https://codereview.adblockplus.org/29345737/diff/29353257/libadblockplus-andr...
libadblockplus-android/jni/JniLibrary.cpp:19: 
added #include "Utils.h" for ABP_JNI_VERSION to be available in final commit
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5