Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(139)

Issue 29346613: Issue 521 - Inject our stylesheet on per-site basis rather than globally (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by Wladimir Palant
Modified:
3 years, 3 months ago
Reviewers:
Thomas Greiner
CC:
tschuster
Visibility:
Public.

Description

Issue 521 - Inject our stylesheet on per-site basis rather than globally Repository: hg.adblockplus.org/adblockplus

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -79 lines) Patch
M lib/child/elemHide.js View 2 chunks +62 lines, -0 lines 2 comments Download
M lib/child/main.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/elemHideFF.js View 1 chunk +20 lines, -77 lines 0 comments Download
M lib/main.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Wladimir Palant
3 years, 4 months ago (2016-06-17 14:06:02 UTC) #1
Thomas Greiner
https://codereview.adblockplus.org/29346613/diff/29346619/lib/child/elemHide.js File lib/child/elemHide.js (right): https://codereview.adblockplus.org/29346613/diff/29346619/lib/child/elemHide.js#newcode319 lib/child/elemHide.js:319: this.sheet = null; If I understand this correctly, we ...
3 years, 3 months ago (2016-06-23 14:12:43 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29346613/diff/29346619/lib/child/elemHide.js File lib/child/elemHide.js (right): https://codereview.adblockplus.org/29346613/diff/29346619/lib/child/elemHide.js#newcode319 lib/child/elemHide.js:319: this.sheet = null; On 2016/06/23 14:12:42, Thomas Greiner wrote: ...
3 years, 3 months ago (2016-06-29 16:18:21 UTC) #3
Thomas Greiner
3 years, 3 months ago (2016-06-29 16:35:56 UTC) #4
LGTM

On 2016/06/29 16:18:21, Wladimir Palant wrote:
> Element Hiding Helper will have to be adjusted slightly, I guess that ideally
it
> should make sure the styles for the current webpage get reapplied.

Agreed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5