Issue 521 - Inject our stylesheet on per-site basis rather than globally

Issue 521 - Inject our stylesheet on per-site basis rather than globally

Repository: hg.adblockplus.org/adblockplus

[Thomas Greiner, 2016-06-23 14:12:43]

https://codereview.adblockplus.org/29346613/diff/29346619/lib/child/elemHide.js
File lib/child/elemHide.js (right):

https://codereview.adblockplus.org/29346613/diff/29346619/lib/child/elemHide....
lib/child/elemHide.js:319: this.sheet = null;
If I understand this correctly, we no longer apply changes in element hiding
rules right away but only after the page reloads. That'd be a regression to the
current behavior in Firefox (and probably also Element Hiding Helper) even
though that's how the extension currently behaves on other platforms.

If so, was this change intentional to make it more consistent with our other
versions or is this a performance optimization?

[Wladimir Palant, 2016-06-29 16:18:21]

https://codereview.adblockplus.org/29346613/diff/29346619/lib/child/elemHide.js
File lib/child/elemHide.js (right):

https://codereview.adblockplus.org/29346613/diff/29346619/lib/child/elemHide....
lib/child/elemHide.js:319: this.sheet = null;
On 2016/06/23 14:12:42, Thomas Greiner wrote:
> If I understand this correctly, we no longer apply changes in element hiding
> rules right away but only after the page reloads. That'd be a regression to
the
> current behavior in Firefox (and probably also Element Hiding Helper) even
> though that's how the extension currently behaves on other platforms.
> 
> If so, was this change intentional to make it more consistent with our other
> versions or is this a performance optimization?

Yes, this is very much desirable and indeed listed under "issues solved" in the
description of https://issues.adblockplus.org/ticket/521.

Element Hiding Helper will have to be adjusted slightly, I guess that ideally it
should make sure the styles for the current webpage get reapplied.

[Thomas Greiner, 2016-06-29 16:35:56]

LGTM

On 2016/06/29 16:18:21, Wladimir Palant wrote:
> Element Hiding Helper will have to be adjusted slightly, I guess that ideally
it
> should make sure the styles for the current webpage get reapplied.

Agreed.