Issue 29347167: Issue 4210 - Fix dynamic-frame collapsing in Chrome

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29347167: Issue 4210 - Fix dynamic-frame collapsing in Chrome (Closed)

Created:
June 30, 2016, 1:39 p.m. by kzar

Modified:
Aug. 11, 2016, 3:37 p.m.

Reviewers:
Sebastian Noack

CC:
Thomas Greiner

Visibility:
Public.

Description

Issue 4210 - Fix dynamic-frame collapsing in Chrome

Patch Set 1 #

Total comments: 1

Created: June 30, 2016, 1:39 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -13 lines)			Patch
	M	include.preload.js	View		3 chunks	+15 lines, -9 lines	1 comment	Download
	M	lib/requestBlocker.js	View		1 chunk	+13 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Sebastian Noack

Aug. 10, 2016, 12:38 p.m. (2016-08-10 12:38:52 UTC) #2

https://codereview.adblockplus.org/29347167/diff/29347168/include.preload.js
File include.preload.js (left):

https://codereview.adblockplus.org/29347167/diff/29347168/include.preload.js#...
include.preload.js:556: if (!contentWindow.collapsing)
I'd rather remove this workaround than adding yet another workaround for side
effects of this workaround. Note that we already removed this code path in the
build for Edge to prevent another issue.

The worst that could happen is that some placeholders show up again (if the
Chrome bug still exists). However, at least I cannot reproduce the original
issue (#581) on chip.de anymore if I remove that code (though this might be as
well because they changed their website).

Expand All Messages | Collapse All Messages