Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29347424: Issue 4037 - Update the user numbers on eyeo.com (Closed)

Created:
July 8, 2016, 5:43 p.m. by juliandoucette
Modified:
Aug. 22, 2016, 10:07 a.m.
Reviewers:
saroyanm
CC:
tamara, Thomas Greiner
Visibility:
Public.

Description

Issue 4037 - Update the user numbers on eyeo.com

Patch Set 1 #

Patch Set 2 : Fixed string on jobs page and removed extra whitespace #

Total comments: 2

Patch Set 3 : Removed extra newline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M includes/index/whoweare.md View 1 2 1 chunk +1 line, -1 line 0 comments Download
M includes/jobs/overview.md View 1 1 chunk +1 line, -1 line 0 comments Download
M includes/press/facts.md View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10
juliandoucette
July 8, 2016, 5:43 p.m. (2016-07-08 17:43:35 UTC) #1
juliandoucette
See comment on https://codereview.adblockplus.org/29347420/#msg2
July 8, 2016, 5:44 p.m. (2016-07-08 17:44:26 UTC) #2
juliandoucette
On 2016/07/08 17:44:26, juliandoucette wrote: > See comment on https://codereview.adblockplus.org/29347420/#msg2 Scratch that. No translations in ...
July 8, 2016, 5:45 p.m. (2016-07-08 17:45:24 UTC) #3
saroyanm
According to the ticket, we do have another string on Eyeo.com in the Jobs page.
July 11, 2016, 8:26 a.m. (2016-07-11 08:26:29 UTC) #4
juliandoucette
On 2016/07/11 08:26:29, saroyanm wrote: > According to the ticket, we do have another string ...
July 11, 2016, 1:06 p.m. (2016-07-11 13:06:53 UTC) #5
juliandoucette
On 2016/07/11 13:06:53, juliandoucette wrote: > On 2016/07/11 08:26:29, saroyanm wrote: > > According to ...
July 12, 2016, 3:09 p.m. (2016-07-12 15:09:49 UTC) #6
saroyanm
https://codereview.adblockplus.org/29347424/diff/29347688/includes/index/whoweare.md File includes/index/whoweare.md (right): https://codereview.adblockplus.org/29347424/diff/29347688/includes/index/whoweare.md#newcode4 includes/index/whoweare.md:4: With the help of an international community of volunteers, ...
July 25, 2016, 12:40 p.m. (2016-07-25 12:40:05 UTC) #7
juliandoucette
Should be a quick one. No <fix> here because there are no translations. https://codereview.adblockplus.org/29347424/diff/29347688/includes/index/whoweare.md File ...
Aug. 16, 2016, 4:48 p.m. (2016-08-16 16:48:26 UTC) #8
saroyanm
LGTM
Aug. 17, 2016, 3:54 p.m. (2016-08-17 15:54:59 UTC) #9
juliandoucette
Aug. 22, 2016, 10:07 a.m. (2016-08-22 10:07:30 UTC) #10 
On 2016/08/17 15:54:59, saroyanm wrote:
> LGTM

https://hg.adblockplus.org/web.eyeo.com/rev/862b3960c69e

Powered by Google App Engine
This is Rietveld