Issue #1234 - Remove transitional conversion functions for CString

Issue #1234 - Remove transitional conversion functions for CString

Remove the CString conversion functions 'ToWstring()' and 'ToCString()'. Remove
ATL_Deprecate.cpp, whose only remaining code was their implementations.

Add a header inclusion to PluginDebug.h that had been coming from the
declaration of the conversion functions. Removed the last use of 'ToWstring()';
it was already redundant.

[Eric, 2016-07-15 18:33:12]

Removing ATL_Deprecate.h is far more a build issue. I'm deferring it to a later
change set.

[RastaJedi, 2016-07-16 19:41:19]

I probably don't know what I'm talking about but I saw something that I wasn't
sure about so I figured I'd ask about it just in case!

https://codereview.adblockplus.org/29347788/diff/29347789/src/plugin/AdblockP...
File src/plugin/AdblockPlusDomTraverser.cpp (right):

https://codereview.adblockplus.org/29347788/diff/29347789/src/plugin/AdblockP...
src/plugin/AdblockPlusDomTraverser.cpp:149: DEBUG_HIDE_EL(ToWstring(indent) +
L"HideEl::Hiding " + type + L" url:" + url)
You said you removed last reference to `ToWstring()`? I am probably wrong here
but what about `ToWstring(indent)`?

[RastaJedi, 2016-07-16 19:44:58]

On 2016/07/16 19:41:19, RastaJedi wrote:
> I probably don't know what I'm talking about but I saw something that I wasn't
> sure about so I figured I'd ask about it just in case!
> 
>
https://codereview.adblockplus.org/29347788/diff/29347789/src/plugin/AdblockP...
> File src/plugin/AdblockPlusDomTraverser.cpp (right):
> 
>
https://codereview.adblockplus.org/29347788/diff/29347789/src/plugin/AdblockP...
> src/plugin/AdblockPlusDomTraverser.cpp:149: DEBUG_HIDE_EL(ToWstring(indent) +
> L"HideEl::Hiding " + type + L" url:" + url)
> You said you removed last reference to `ToWstring()`? I am probably wrong here
> but what about `ToWstring(indent)`?

Actually I think I was just misunderstanding your description; when you said
"removed last use of `ToWstring()`" I think you just meant the *last* one on
that line... not like the *last* one in existence. So I don't think you were
intending to remove all, just the last one on that line because that last one
was redundant. See, I didn't think I knew what I was talking about! So I think
you can safely ignore me :).

[RastaJedi, 2016-07-16 19:46:07]

https://codereview.adblockplus.org/29347788/diff/29347789/src/plugin/AdblockP...
File src/plugin/AdblockPlusDomTraverser.cpp (right):

https://codereview.adblockplus.org/29347788/diff/29347789/src/plugin/AdblockP...
src/plugin/AdblockPlusDomTraverser.cpp:149: DEBUG_HIDE_EL(ToWstring(indent) +
L"HideEl::Hiding " + type + L" url:" + url)
On 2016/07/16 19:41:18, RastaJedi wrote:
> You said you removed last reference to `ToWstring()`? I am probably wrong here
> but what about `ToWstring(indent)`?

Ignore me!

[Eric, 2016-07-17 14:24:23]

Patch set 2 fixes a second occurrence of ToWstring in the argument of a disabled
macro.

https://codereview.adblockplus.org/29347788/diff/29347789/src/plugin/AdblockP...
File src/plugin/AdblockPlusDomTraverser.cpp (right):

https://codereview.adblockplus.org/29347788/diff/29347789/src/plugin/AdblockP...
src/plugin/AdblockPlusDomTraverser.cpp:149: DEBUG_HIDE_EL(ToWstring(indent) +
L"HideEl::Hiding " + type + L" url:" + url)
On 2016/07/16 19:41:18, RastaJedi wrote:
> You said you removed last reference to `ToWstring()`? I am probably wrong here
> but what about `ToWstring(indent)`?

No, this is right.

The macro DEBUG_HIDE_EL is turned off by default, so the compiler doesn't type
check its argument. If it had, it would have shown up. I've been bitten by
exactly this before.

[sergei, 2016-07-19 07:31:29]

LGTM

[Oleksandr, 2016-07-21 23:36:46]

Amen. I mean LGTM.