Issue 4251 - Fixed hang trying to apply element hiding rules to blocked frames

lib/child/elemHide.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 310 matching lines @@
   },
 
   observe: function(subject, topic, data)
   {
     if (topic != this.topic)
       return;
 
     if (subject.document.readyState == "uninitialized")
     {
       // It would be nice to listen to the readystatechange event here. However,
-      // it doesn't fire when changing from "uninitialized" state.
-      Utils.runAsync(() =>
+      // adding event listeners on uninitialized documents isn't possible. So
+      // we listen for DOMContentLoaded and beforescriptexecute - whichever
+      // fires first.
+      let listener = () =>
       {
-        if (!Cu.isDeadWrapper(subject))
-          this.observe(subject, topic, data);
-      });
+        subject.removeEventListener("DOMContentLoaded", listener);
+        subject.removeEventListener("beforescriptexecute", listener);
+        this.observe(subject, topic, data);
+      };
+      subject.addEventListener("DOMContentLoaded", listener);
+      subject.addEventListener("beforescriptexecute", listener);

[Wladimir Palant, 2016/07/19 16:23:25]

For reference, DOMContentLoaded fires too late - with the test case from
https://issues.adblockplus.org/ticket/4211 I can see a noticeable delay (below
one second but still). In most cases, beforescriptexecute will fire way earlier
- especially in the scenarios that are relevant for us. With this additional
event listener I can no longer see the ads disappearing.

       return;
     }
 
     port.emitWithResponse("elemhideEnabled", {
       frames: getFrames(subject),
       isPrivate: isPrivate(subject)
     }).then(({
       enabled, contentType, docDomain, thirdParty, location, filter,
       filterType
     }) =>
@@ skipping 30 matching lines @@
       else if (filter)
       {
         RequestNotifier.addNodeData(subject.document, subject.top, {
           contentType, docDomain, thirdParty, location, filter, filterType
         });
       }
     });
   }
 };
 observer.init();