Issue 29348026: Issue 4251 - Fixed hang trying to apply element hiding rules to blocked frames

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29348026: Issue 4251 - Fixed hang trying to apply element hiding rules to blocked frames (Closed)

Created:
July 19, 2016, 4:19 p.m. by Wladimir Palant

Modified:
July 19, 2016, 4:23 p.m.

Reviewers:
Thomas Greiner

Visibility:
Public.

Description

Issue 4251 - Fixed hang trying to apply element hiding rules to blocked frames Repository: hg.adblockplus.org/adblockplus

Patch Set 1 #

Total comments: 1

Created: July 19, 2016, 4:19 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	lib/child/elemHide.js	View		1 chunk	+10 lines, -5 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Wladimir Palant

July 19, 2016, 4:23 p.m. (2016-07-19 16:23:25 UTC) #3

https://codereview.adblockplus.org/29348026/diff/29348027/lib/child/elemHide.js
File lib/child/elemHide.js (right):

https://codereview.adblockplus.org/29348026/diff/29348027/lib/child/elemHide....
lib/child/elemHide.js:341: subject.addEventListener("beforescriptexecute",
listener);
For reference, DOMContentLoaded fires too late - with the test case from
https://issues.adblockplus.org/ticket/4211 I can see a noticeable delay (below
one second but still). In most cases, beforescriptexecute will fire way earlier
- especially in the scenarios that are relevant for us. With this additional
event listener I can no longer see the ads disappearing.

Expand All Messages | Collapse All Messages