Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29349225: Issue 4313 - hg review shouldn't fail if the repository has no URL configured (Closed)

Created:
Aug. 8, 2016, 7:06 p.m. by Wladimir Palant
Modified:
Aug. 17, 2016, 10:14 a.m.
Reviewers:
Vasily Kuznetsov
Visibility:
Public.

Description

Issue 4313 - hg review shouldn't fail if the repository has no URL configured Repository: hg.adblockplus.org/codingtools/

Patch Set 1 #

Total comments: 2

Patch Set 2 : Structure the code a bit better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M hgreview.py View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Aug. 8, 2016, 7:06 p.m. (2016-08-08 19:06:15 UTC) #1
Vasily Kuznetsov
LGTM https://codereview.adblockplus.org/29349225/diff/29349226/hgreview.py File hgreview.py (right): https://codereview.adblockplus.org/29349225/diff/29349226/hgreview.py#newcode69 hgreview.py:69: match = re.search(r'^(?:https://|ssh://hg@)(.*)', path or '') Perhaps it ...
Aug. 16, 2016, 8:50 a.m. (2016-08-16 08:50:48 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29349225/diff/29349226/hgreview.py File hgreview.py (right): https://codereview.adblockplus.org/29349225/diff/29349226/hgreview.py#newcode69 hgreview.py:69: match = re.search(r'^(?:https://|ssh://hg@)(.*)', path or '') On 2016/08/16 08:50:48, ...
Aug. 16, 2016, 10:37 a.m. (2016-08-16 10:37:11 UTC) #3
Vasily Kuznetsov
Aug. 16, 2016, 1:04 p.m. (2016-08-16 13:04:38 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld