Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(410)

Issue 29349240: Issue 4218 - Browser icons for newer Chrome + Edge (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 7 months ago by kzar
Modified:
3 years, 7 months ago
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 4218 - Browser icons for newer Chrome + Edge

Patch Set 1 #

Total comments: 1

Patch Set 2 : Improved 20px icons, compressed with pngout #

Patch Set 3 : Avoid JSHydra generating inefficient code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -5 lines) Patch
M chrome/ext/background.js View 1 chunk +5 lines, -1 line 0 comments Download
A chrome/icons/abp-16.png View 1 Binary file 0 comments Download
A chrome/icons/abp-16-notification-critical.png View 1 Binary file 0 comments Download
A chrome/icons/abp-16-notification-information.png View 1 Binary file 0 comments Download
A chrome/icons/abp-16-whitelisted.png View 1 Binary file 0 comments Download
A chrome/icons/abp-20.png View 1 Binary file 0 comments Download
A chrome/icons/abp-20-notification-critical.png View 1 Binary file 0 comments Download
A chrome/icons/abp-20-notification-information.png View 1 Binary file 0 comments Download
A chrome/icons/abp-20-whitelisted.png View 1 Binary file 0 comments Download
A chrome/icons/abp-32.png View 1 Binary file 0 comments Download
A chrome/icons/abp-32-notification-critical.png View 1 Binary file 0 comments Download
A chrome/icons/abp-32-notification-information.png View 1 Binary file 0 comments Download
A chrome/icons/abp-32-whitelisted.png View 1 Binary file 0 comments Download
A chrome/icons/abp-40.png View 1 Binary file 0 comments Download
A chrome/icons/abp-40-notification-critical.png View 1 Binary file 0 comments Download
A chrome/icons/abp-40-notification-information.png View 1 Binary file 0 comments Download
A chrome/icons/abp-40-whitelisted.png View 1 Binary file 0 comments Download
M lib/icon.js View 1 2 2 chunks +20 lines, -3 lines 0 comments Download
M metadata.chrome View 2 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 4
kzar
Patch Set 1
3 years, 7 months ago (2016-08-09 11:11:13 UTC) #1
Sebastian Noack
Also, as discussed on IRC: 1. The 20px icons look extremely blurry (like they were ...
3 years, 7 months ago (2016-08-09 13:46:47 UTC) #2
kzar
Patch Set 2 : Improved 20px icons, compressed with pngout Patch Set 3 : Avoid ...
3 years, 7 months ago (2016-08-09 13:55:07 UTC) #3
Sebastian Noack
3 years, 7 months ago (2016-08-09 13:57:08 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5