Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: firstRun.js

Issue 29349840: Issue 4294 - Removed feature section from first-run page (Closed)
Patch Set: Created Aug. 16, 2016, 9:59 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: firstRun.js
===================================================================
--- a/firstRun.js
+++ b/firstRun.js
@@ -19,28 +19,6 @@
(function()
{
- // Load subscriptions for features
- var featureSubscriptions = [
- {
- feature: "malware",
- homepage: "http://malwaredomains.com/",
- title: "Malware Domains",
- url: "https://easylist-downloads.adblockplus.org/malwaredomains_full.txt"
- },
- {
- feature: "social",
- homepage: "https://www.fanboy.co.nz/",
- title: "Fanboy's Social Blocking List",
- url: "https://easylist-downloads.adblockplus.org/fanboy-social.txt"
- },
- {
- feature: "tracking",
- homepage: "https://easylist.adblockplus.org/",
- title: "EasyPrivacy",
- url: "https://easylist-downloads.adblockplus.org/easyprivacy.txt"
- }
- ];
-
function onDOMLoaded()
{
// Set up logo image
@@ -91,16 +69,12 @@
E("legacySafariWarning").removeAttribute("hidden");
});
- // Set up feature buttons linked to subscriptions
- featureSubscriptions.forEach(initToggleSubscriptionButton);
- updateToggleButtons();
updateSocialLinks();
ext.onMessage.addListener(function(message)
{
if (message.type == "subscriptions.respond")
{
- updateToggleButtons();
updateSocialLinks();
}
});
@@ -110,22 +84,6 @@
});
}
- function initToggleSubscriptionButton(featureSubscription)
- {
- var feature = featureSubscription.feature;
-
- var element = E("toggle-" + feature);
- element.addEventListener("click", function(event)
- {
- ext.backgroundPage.sendMessage({
- type: "subscriptions.toggle",
- url: featureSubscription.url,
- title: featureSubscription.title,
- homepage: featureSubscription.homepage
- });
- }, false);
- }
-
function updateSocialLinks()
{
var networks = ["twitter", "facebook", "gplus"];
@@ -186,33 +144,5 @@
ext.backgroundPage.sendMessage({type: "app.open", what: "options"});
}
- function updateToggleButtons()
- {
- ext.backgroundPage.sendMessage({
- type: "subscriptions.get",
- downloadable: true,
- ignoreDisabled: true
- }, function(subscriptions)
- {
- var known = Object.create(null);
- for (var i = 0; i < subscriptions.length; i++)
- known[subscriptions[i].url] = true;
- for (var i = 0; i < featureSubscriptions.length; i++)
- {
- var featureSubscription = featureSubscriptions[i];
- updateToggleButton(featureSubscription.feature, featureSubscription.url in known);
- }
- });
- }
-
- function updateToggleButton(feature, isEnabled)
- {
- var button = E("toggle-" + feature);
- if (isEnabled)
- button.classList.remove("off");
- else
- button.classList.add("off");
- }
-
document.addEventListener("DOMContentLoaded", onDOMLoaded, false);
})();

Powered by Google App Engine
This is Rietveld