Issue 4294 - Removed feature section from first-run page

Note that the /skin/features/ directory will also be removed but Rietveld doesn't reflect that.

[saroyanm, 2016-08-16 12:00:13]

Looks fine, just two comments.

https://codereview.adblockplus.org/29349840/diff/29349841/firstRun.html
File firstRun.html (left):

https://codereview.adblockplus.org/29349840/diff/29349841/firstRun.html#oldco...
firstRun.html:115: <div class="feature-image feature-social-image"></div>
What about feature images themselves ? 
I think the skin/features directory can be deleted completely.

https://codereview.adblockplus.org/29349840/diff/29349841/locale/en-US/firstR...
File locale/en-US/firstRun.json (left):

https://codereview.adblockplus.org/29349840/diff/29349841/locale/en-US/firstR...
locale/en-US/firstRun.json:26: "firstRun_feature_malware": {
What about translations ? Are they being removed by some script ?

[Thomas Greiner, 2016-08-16 13:12:00]

https://codereview.adblockplus.org/29349840/diff/29349841/firstRun.html
File firstRun.html (left):

https://codereview.adblockplus.org/29349840/diff/29349841/firstRun.html#oldco...
firstRun.html:115: <div class="feature-image feature-social-image"></div>
On 2016/08/16 12:00:11, saroyanm wrote:
> What about feature images themselves ? 
> I think the skin/features directory can be deleted completely.

I mentioned this in the review description. Admittingly, I added it after I sent
out the email because I forgot it before. :)

But yes, that will be removed.

https://codereview.adblockplus.org/29349840/diff/29349841/locale/en-US/firstR...
File locale/en-US/firstRun.json (left):

https://codereview.adblockplus.org/29349840/diff/29349841/locale/en-US/firstR...
locale/en-US/firstRun.json:26: "firstRun_feature_malware": {
On 2016/08/16 12:00:12, saroyanm wrote:
> What about translations ? Are they being removed by some script ?

Any language files apart from the U.S. english ones are automatically created so
if unused texts aren't being removed, I'd consider it to be an issue with the
script that creates those.

[saroyanm, 2016-08-16 13:20:32]

LGTM

https://codereview.adblockplus.org/29349840/diff/29349841/firstRun.html
File firstRun.html (left):

https://codereview.adblockplus.org/29349840/diff/29349841/firstRun.html#oldco...
firstRun.html:115: <div class="feature-image feature-social-image"></div>
On 2016/08/16 13:12:00, Thomas Greiner wrote:
> On 2016/08/16 12:00:11, saroyanm wrote:
> > What about feature images themselves ? 
> > I think the skin/features directory can be deleted completely.
> 
> I mentioned this in the review description. Admittingly, I added it after I
sent
> out the email because I forgot it before. :)
> 
> But yes, that will be removed. 

OOps sorry, missed that.

https://codereview.adblockplus.org/29349840/diff/29349841/locale/en-US/firstR...
File locale/en-US/firstRun.json (left):

https://codereview.adblockplus.org/29349840/diff/29349841/locale/en-US/firstR...
locale/en-US/firstRun.json:26: "firstRun_feature_malware": {
On 2016/08/16 13:12:00, Thomas Greiner wrote:
> On 2016/08/16 12:00:12, saroyanm wrote:
> > What about translations ? Are they being removed by some script ?
> 
> Any language files apart from the U.S. english ones are automatically created
so
> if unused texts aren't being removed, I'd consider it to be an issue with the
> script that creates those.

Acknowledged.