Issue 4337 - Don't use -k command line switch when creating Firefox builds

Issue 4337 - Don't use -k command line switch when creating Firefox builds

Repository: hg.adblockplus.org/sitescripts

[Sebastian Noack, 2016-08-16 12:27:54]

https://codereview.adblockplus.org/29349846/diff/29349847/sitescripts/extensi...
File sitescripts/extensions/bin/createNightlies.py (right):

https://codereview.adblockplus.org/29349846/diff/29349847/sitescripts/extensi...
sitescripts/extensions/bin/createNightlies.py:326: buildCommand =
([os.path.join(self.tempdir, 'build.py'),
I think it's a little simpler and more readable if you write it like that:

  build_command = [os.path.join(self.tempdir, 'build.py'),
                   '-t', self.config.type, 'build',
                   '-b', self.buildNum]
  if self.config.type != 'gecko':
      build_command.expand(['-k', self.config.keyFile])
  build_command.append(self.path)

[Wladimir Palant, 2016-08-16 13:33:09]

https://codereview.adblockplus.org/29349846/diff/29349847/sitescripts/extensi...
File sitescripts/extensions/bin/createNightlies.py (right):

https://codereview.adblockplus.org/29349846/diff/29349847/sitescripts/extensi...
sitescripts/extensions/bin/createNightlies.py:326: buildCommand =
([os.path.join(self.tempdir, 'build.py'),
On 2016/08/16 12:27:54, Sebastian Noack wrote:
> I think it's a little simpler and more readable if you write it like that:
> 
>   build_command = [os.path.join(self.tempdir, 'build.py'),
>                    '-t', self.config.type, 'build',
>                    '-b', self.buildNum]
>   if self.config.type != 'gecko':
>       build_command.expand(['-k', self.config.keyFile])
>   build_command.append(self.path)

Done.

[Sebastian Noack, 2016-08-16 16:06:58]

https://codereview.adblockplus.org/29349846/diff/29349867/sitescripts/extensi...
File sitescripts/extensions/bin/createNightlies.py (right):

https://codereview.adblockplus.org/29349846/diff/29349867/sitescripts/extensi...
sitescripts/extensions/bin/createNightlies.py:321: buildCommand =
[os.path.join(self.tempdir, 'build.py'),
Nit: Is this variable also used somewhere else? Otherwise, this would be a good
change to convert it to camel case.

https://codereview.adblockplus.org/29349846/diff/29349867/sitescripts/extensi...
sitescripts/extensions/bin/createNightlies.py:323: if self.config.type !=
"gecko":
Nit: As per our coding style guide, and already done in the rest of the code
here, prefer single quotes over double quotes.

[Wladimir Palant, 2016-08-17 10:13:54]

https://codereview.adblockplus.org/29349846/diff/29349867/sitescripts/extensi...
File sitescripts/extensions/bin/createNightlies.py (right):

https://codereview.adblockplus.org/29349846/diff/29349867/sitescripts/extensi...
sitescripts/extensions/bin/createNightlies.py:321: buildCommand =
[os.path.join(self.tempdir, 'build.py'),
On 2016/08/16 16:06:57, Sebastian Noack wrote:
> Nit: Is this variable also used somewhere else? Otherwise, this would be a
good
> change to convert it to camel case.

Done.

https://codereview.adblockplus.org/29349846/diff/29349867/sitescripts/extensi...
sitescripts/extensions/bin/createNightlies.py:323: if self.config.type !=
"gecko":
On 2016/08/16 16:06:57, Sebastian Noack wrote:
> Nit: As per our coding style guide, and already done in the rest of the code
> here, prefer single quotes over double quotes.

Done.

[Sebastian Noack, 2016-08-17 10:21:00]

LGTM