Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29349925: Issue #4338, #3391 - Remove registered window class for the status bar

Created:
Aug. 17, 2016, 12:30 p.m. by Eric
Modified:
Aug. 17, 2016, 1:24 p.m.
Reviewers:
sergei, Oleksandr
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue #4338, #3391 - Remove registered window class for the status bar [#4338] Remove application-specific window class for creating status bar windows. Accordingly, remove 's_atomPanClass' and 'GetAtomPaneClass()', which managed a class atom, and STATUS_BAR_PANE_NAME, the name of the ABP window class. Instead, create windows using the system window class "Edit". Add window names when creating them; this is useful for debugging and has no user-visible effect. Add 'SetWindowProc()', a type-safe wrapper for API 'SetWindowLongptr()' to set window procedures. This replaces setting the window procedure by means of a window class atom. [#3391] Remove initialization code for the window class atom from 'InitObject()', the thread-main function for the detached initialization thread. [Noissue] Move STATUS_BAR_PANE_NUMBER to PluginClass.cpp. This is an implementation detail of the status bar and has no global significance.

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -53 lines) Patch
M src/plugin/Config.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/plugin/PluginClass.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/plugin/PluginClass.cpp View 9 chunks +44 lines, -42 lines 0 comments Download

Messages

Total messages: 1
Eric
Aug. 17, 2016, 1:24 p.m. (2016-08-17 13:24:49 UTC) #1

          

Powered by Google App Engine
This is Rietveld