Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(304)

Issue 29349976: Issue 4346 - Fix exception when creating Safari builds caused by buildtools changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 5 months ago by Wladimir Palant
Modified:
3 years, 5 months ago
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 4346 - Fix exception when creating Safari builds caused by buildtools changes Repository: hg.adblockplus.org/sitescripts

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -91 lines) Patch
M dependencies View 1 chunk +1 line, -1 line 0 comments Download
M ensure_dependencies.py View 4 chunks +88 lines, -89 lines 0 comments Download
M sitescripts/extensions/bin/createNightlies.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5
Wladimir Palant
3 years, 5 months ago (2016-08-19 12:38:10 UTC) #1
Sebastian Noack
I think the dependency update should go into a seperate commit. Wouldn't insist on a ...
3 years, 5 months ago (2016-08-19 12:51:33 UTC) #2
Wladimir Palant
On 2016/08/19 12:51:33, Sebastian Noack wrote: > I think the dependency update should go into ...
3 years, 5 months ago (2016-08-19 13:06:10 UTC) #3
Sebastian Noack
On 2016/08/19 13:06:10, Wladimir Palant wrote: > On 2016/08/19 12:51:33, Sebastian Noack wrote: > > ...
3 years, 5 months ago (2016-08-19 13:19:38 UTC) #4
Wladimir Palant
3 years, 5 months ago (2016-08-19 13:23:08 UTC) #5
Message was sent while issue was closed.
On 2016/08/19 13:19:38, Sebastian Noack wrote:
> That's a good point, though only true for developers working on the code, not
> for the server that always uses the latest buildtools. LGTM.

I'd consider the current server setup a bug - we made it consider dependencies
properly for the project repositories, same should be done for sitescripts
itself.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5