Issue 4346 - Fix exception when creating Safari builds caused by buildtools changes

Issue 4346 - Fix exception when creating Safari builds caused by buildtools changes

Repository: hg.adblockplus.org/sitescripts

[Sebastian Noack, 2016-08-19 12:51:33]

I think the dependency update should go into a seperate commit. Wouldn't insist
on a separate issue though. Otherwise, LGTM.

[Wladimir Palant, 2016-08-19 13:06:10]

On 2016/08/19 12:51:33, Sebastian Noack wrote:
> I think the dependency update should go into a seperate commit. Wouldn't
insist
> on a separate issue though. Otherwise, LGTM.

Given that this change is required for the code to work after the dependency
update - I disagree. If we split it up we will create a broken state between the
two commits.

[Sebastian Noack, 2016-08-19 13:19:38]

On 2016/08/19 13:06:10, Wladimir Palant wrote:
> On 2016/08/19 12:51:33, Sebastian Noack wrote:
> > I think the dependency update should go into a seperate commit. Wouldn't
> insist
> > on a separate issue though. Otherwise, LGTM.
> 
> Given that this change is required for the code to work after the dependency
> update - I disagree. If we split it up we will create a broken state between
the
> two commits.

That's a good point, though only true for developers working on the code, not
for the server that always uses the latest buildtools. LGTM.

[Wladimir Palant, 2016-08-19 13:23:08]

On 2016/08/19 13:19:38, Sebastian Noack wrote:
> That's a good point, though only true for developers working on the code, not
> for the server that always uses the latest buildtools. LGTM.

I'd consider the current server setup a bug - we made it consider dependencies
properly for the project repositories, same should be done for sitescripts
itself.