Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29349989: Issue 4327 - Prevent generic document blocking (Closed)

Created:
Aug. 19, 2016, 5:55 p.m. by kzar
Modified:
June 16, 2017, 3:01 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 4327 - Prevent generic document blocking

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
M lib/abp2blocklist.js View 1 1 chunk +11 lines, -0 lines 0 comments Download
M test/abp2blocklist.js View 1 3 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 4
kzar
Patch Set 1
Aug. 19, 2016, 5:57 p.m. (2016-08-19 17:57:03 UTC) #1
Sebastian Noack
Since we are not sure yet, whether we want to go with that approach, mind ...
Aug. 20, 2016, 2:04 p.m. (2016-08-20 14:04:27 UTC) #2
kzar
I also considered making this feature controlled by a parameter, but then I figured it ...
Aug. 22, 2016, 12:50 p.m. (2016-08-22 12:50:20 UTC) #3
kzar
Aug. 22, 2016, 4:32 p.m. (2016-08-22 16:32:09 UTC) #4
Patch Set 2 : Rebased.

Powered by Google App Engine
This is Rietveld