Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29350056: Issue 4348 - control adware page warning through url parameter (Closed)

Created:
Aug. 22, 2016, 3:36 p.m. by saroyanm
Modified:
Sept. 26, 2016, 4:57 p.m.
Reviewers:
juliandoucette
Visibility:
Public.

Description

Issue 4348 - control adware page warning through url parameter

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add the class, don't rewrite #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M pages/adware.md View 1 3 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5
saroyanm
Aug. 22, 2016, 3:37 p.m. (2016-08-22 15:37:57 UTC) #1
juliandoucette
On 2016/08/22 15:37:57, saroyanm wrote: One minor issue. Looks good otherwise.
Sept. 22, 2016, 2:24 p.m. (2016-09-22 14:24:48 UTC) #2
juliandoucette
One minor issue. Looks good otherwise. https://codereview.adblockplus.org/29350056/diff/29350057/pages/adware.md File pages/adware.md (right): https://codereview.adblockplus.org/29350056/diff/29350057/pages/adware.md#newcode145 pages/adware.md:145: document.body.className = "show-warning"; ...
Sept. 22, 2016, 2:25 p.m. (2016-09-22 14:25:10 UTC) #3
saroyanm
https://codereview.adblockplus.org/29350056/diff/29350057/pages/adware.md File pages/adware.md (right): https://codereview.adblockplus.org/29350056/diff/29350057/pages/adware.md#newcode145 pages/adware.md:145: document.body.className = "show-warning"; On 2016/09/22 14:25:10, juliandoucette wrote: > ...
Sept. 22, 2016, 2:57 p.m. (2016-09-22 14:57:45 UTC) #4
juliandoucette
Sept. 26, 2016, 2:57 p.m. (2016-09-26 14:57:03 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld