Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1059)

Issue 29350140: Issue 4353 - Remove non standard for each syntax (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 2 months ago by kzar
Modified:
3 years, 2 months ago
Visibility:
Public.

Description

Issue 4353 - Remove non standard for each syntax

Patch Set 1 #

Total comments: 6

Patch Set 2 : Removed unused code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1960 lines) Patch
D scripts/ast.js View 1 1 chunk +0 lines, -7 lines 0 comments Download
M scripts/astDecompile.js View 1 13 chunks +23 lines, -117 lines 0 comments Download
D scripts/basic.js View 1 1 chunk +0 lines, -10 lines 0 comments Download
M scripts/decompile.js View 1 1 chunk +0 lines, -454 lines 0 comments Download
M scripts/doxygen.js View 1 1 chunk +0 lines, -81 lines 0 comments Download
M scripts/dxr.js View 1 1 chunk +0 lines, -72 lines 0 comments Download
M scripts/findInterfaces.js View 1 1 chunk +0 lines, -76 lines 0 comments Download
D scripts/outASTML.js View 1 1 chunk +0 lines, -7 lines 0 comments Download
M utils/astml.js View 1 1 chunk +0 lines, -683 lines 0 comments Download
M utils/cleanast.js View 1 1 chunk +0 lines, -248 lines 0 comments Download
M utils/comments.js View 1 1 chunk +0 lines, -86 lines 0 comments Download
M utils/dumpast.js View 1 1 chunk +0 lines, -79 lines 0 comments Download
M utils/jstypes.js View 1 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 5
kzar
Patch Set 1
3 years, 2 months ago (2016-08-24 11:10:02 UTC) #1
Sebastian Noack
LGTM
3 years, 2 months ago (2016-08-24 11:34:13 UTC) #2
Wladimir Palant
I assume that you compared the output of the original version (and old JS Shell) ...
3 years, 2 months ago (2016-08-24 14:21:51 UTC) #3
kzar
Patch Set 2 : Removed unused code Yep, I ran `./build.py -t chrome devenv` before ...
3 years, 2 months ago (2016-08-24 14:43:21 UTC) #4
Wladimir Palant
3 years, 2 months ago (2016-08-24 14:47:53 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5