Issue 4376 - Updated buildtools dependency

Issue 4376 - Updated buildtools dependency

[Sebastian Noack, 2016-08-29 10:16:41]

https://codereview.adblockplus.org/29350286/diff/29350287/dependencies
File dependencies (right):

https://codereview.adblockplus.org/29350286/diff/29350287/dependencies#newcode3
dependencies:3: buildtools =
hg:file:///home/sebastian/src/buildtools@6679f4a8bd41
Temporary hack to test the changes locally. Needs to be replaced with the
upstream revisions, once #4375 and #4047 landed.

[kzar, 2016-08-30 13:44:00]

https://codereview.adblockplus.org/29350286/diff/29350287/dependencies
File dependencies (right):

https://codereview.adblockplus.org/29350286/diff/29350287/dependencies#newcode3
dependencies:3: buildtools =
hg:file:///home/sebastian/src/buildtools@6679f4a8bd41
On 2016/08/29 10:16:41, Sebastian Noack wrote:
> Temporary hack to test the changes locally. Needs to be replaced with the
> upstream revisions, once #4375 and #4047 landed.

(FYI if the repository already existed locally `buildtools = hg:6679f4a8bd41`
would have worked too.)

https://codereview.adblockplus.org/29350286/diff/29350287/metadata.safari
File metadata.safari (right):

https://codereview.adblockplus.org/29350286/diff/29350287/metadata.safari#new...
metadata.safari:10: document_start = ext/common.js ext/content.js
cssProperties.js include.preload.js include.youtube.js
I wonder if we could just do `document_start += include.youtube.js` here
instead?

[Sebastian Noack, 2016-08-30 13:46:33]

https://codereview.adblockplus.org/29350286/diff/29350287/metadata.safari
File metadata.safari (right):

https://codereview.adblockplus.org/29350286/diff/29350287/metadata.safari#new...
metadata.safari:10: document_start = ext/common.js ext/content.js
cssProperties.js include.preload.js include.youtube.js
On 2016/08/30 13:44:00, kzar wrote:
> I wonder if we could just do `document_start += include.youtube.js` here
> instead?

Yes, that should work, and would be preferable. But since this isn't the
[convert_js] section it is unrelated of the dependency update. Feel free to go
ahead and change it.

[kzar, 2016-08-30 14:15:17]

LGTM

https://codereview.adblockplus.org/29350286/diff/29350287/metadata.safari
File metadata.safari (right):

https://codereview.adblockplus.org/29350286/diff/29350287/metadata.safari#new...
metadata.safari:10: document_start = ext/common.js ext/content.js
cssProperties.js include.preload.js include.youtube.js
On 2016/08/30 13:46:33, Sebastian Noack wrote:
> On 2016/08/30 13:44:00, kzar wrote:
> > I wonder if we could just do `document_start += include.youtube.js` here
> > instead?
> 
> Yes, that should work, and would be preferable. But since this isn't the
> [convert_js] section it is unrelated of the dependency update. Feel free to go
> ahead and change it.

I figured this would be a nice change to do at the same time, but seems like you
disagree. Nevermind, doesn't matter too much either way.

[Sebastian Noack, 2016-09-09 15:04:35]

https://codereview.adblockplus.org/29350286/diff/29350287/metadata.safari
File metadata.safari (right):

https://codereview.adblockplus.org/29350286/diff/29350287/metadata.safari#new...
metadata.safari:10: document_start = ext/common.js ext/content.js
cssProperties.js include.preload.js include.youtube.js
On 2016/08/30 14:15:17, kzar wrote:
> On 2016/08/30 13:46:33, Sebastian Noack wrote:
> > On 2016/08/30 13:44:00, kzar wrote:
> > > I wonder if we could just do `document_start += include.youtube.js` here
> > > instead?
> > 
> > Yes, that should work, and would be preferable. But since this isn't the
> > [convert_js] section it is unrelated of the dependency update. Feel free to
go
> > ahead and change it.
> 
> I figured this would be a nice change to do at the same time, but seems like
you
> disagree. Nevermind, doesn't matter too much either way.

Fair enough, done.

[kzar, 2016-09-13 12:53:50]

LGTM