Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29351586: Issue 4023 - Move storage of subscription lists to localStorage - adblockplusedgems (Closed)

Created:
Sept. 8, 2016, 7:31 a.m. by Oleksandr
Modified:
Sept. 13, 2016, 1:49 p.m.
Reviewers:
Sebastian Noack, kzar
Visibility:
Public.

Description

Issue 4023 - Move storage of subscription lists to localStorage

Patch Set 1 #

Patch Set 2 : Rebase to version 0.9.6 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+568 lines, -41 lines) Patch
M background.html View 1 chunk +1 line, -0 lines 0 comments Download
M lib/adblockplus.js View 1 5 chunks +59 lines, -40 lines 1 comment Download
A lib/lz-string.js View 1 chunk +506 lines, -0 lines 0 comments Download
M manifest.json View 1 1 chunk +1 line, -1 line 0 comments Download
M qunit/index.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6
Oleksandr
Sept. 8, 2016, 7:33 a.m. (2016-09-08 07:33:39 UTC) #1
Sebastian Noack
Besides the comments, I already left on the other review, we could consider removing the ...
Sept. 8, 2016, 7:26 p.m. (2016-09-08 19:26:56 UTC) #2
Oleksandr
I realized the previous patch set was based on an older version, witch didn't even ...
Sept. 8, 2016, 11:35 p.m. (2016-09-08 23:35:06 UTC) #3
Sebastian Noack
I cannot see where this patch removes the alert().
Sept. 9, 2016, 1:46 p.m. (2016-09-09 13:46:15 UTC) #4
Oleksandr
I think it may be because you are viewing just a changeset 2 to changeset ...
Sept. 10, 2016, 12:35 a.m. (2016-09-10 00:35:38 UTC) #5
Sebastian Noack
Sept. 10, 2016, 3:54 p.m. (2016-09-10 15:54:50 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld