Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29352637: Issue 4409 - Fixed too large toolbar icon in older Firefox versions on high-DPI screens (Closed)

Created:
Sept. 12, 2016, 9:28 a.m. by Wladimir Palant
Modified:
Sept. 19, 2016, 12:07 p.m.
Reviewers:
saroyanm
Base URL:
https://hg.adblockplus.org/adblockplus
Visibility:
Public.

Description

Issue 4409 - Fixed too large toolbar icon in older Firefox versions on high-DPI screens

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/skin/overlay.css View 1 chunk +8 lines, -0 lines 3 comments Download

Messages

Total messages: 4
Wladimir Palant
Sept. 12, 2016, 9:28 a.m. (2016-09-12 09:28:55 UTC) #1
saroyanm
https://codereview.adblockplus.org/29352637/diff/29352638/chrome/skin/overlay.css File chrome/skin/overlay.css (right): https://codereview.adblockplus.org/29352637/diff/29352638/chrome/skin/overlay.css#newcode47 chrome/skin/overlay.css:47: toolbar[iconsize="small"] #abp-toolbarbutton .toolbarbutton-icon, According to the Ticket description, this ...
Sept. 19, 2016, 10:40 a.m. (2016-09-19 10:40:10 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29352637/diff/29352638/chrome/skin/overlay.css File chrome/skin/overlay.css (right): https://codereview.adblockplus.org/29352637/diff/29352638/chrome/skin/overlay.css#newcode47 chrome/skin/overlay.css:47: toolbar[iconsize="small"] #abp-toolbarbutton .toolbarbutton-icon, On 2016/09/19 10:40:09, saroyanm wrote: > ...
Sept. 19, 2016, 11:08 a.m. (2016-09-19 11:08:40 UTC) #3
saroyanm
Sept. 19, 2016, 11:57 a.m. (2016-09-19 11:57:22 UTC) #4
LGTM

https://codereview.adblockplus.org/29352637/diff/29352638/chrome/skin/overlay...
File chrome/skin/overlay.css (right):

https://codereview.adblockplus.org/29352637/diff/29352638/chrome/skin/overlay...
chrome/skin/overlay.css:47: toolbar[iconsize="small"] #abp-toolbarbutton
.toolbarbutton-icon,
On 2016/09/19 11:08:40, Wladimir Palant wrote:
> On 2016/09/19 10:40:09, saroyanm wrote:
> > According to the Ticket description, this affects only high DPI screens, so
I
> > assume the change should apply only to high DPI screens ? Or this affects
> > regular screens as well ?
> 
> On regular screens the image size happens to match the displayed size.
However,
> setting size explicitly won't hurt - and we avoid duplicating this code for
> 1.5dppx and 2.0dppx.

Acknowledged.

Powered by Google App Engine
This is Rietveld